patchGNU Octave - Patches: patch #10370, [MXE Octave] Launcher doesn't...

 
 

patch #10370: [MXE Octave] Launcher doesn't return Octave's exit code on Windows

Submitter:  Vipul Cariappa <vipul_cariappa>
Submitted:  Sat 15 Jul 2023 03:03:15 PM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  None Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Mon 31 Jul 2023 12:37:30 PM UTC, comment #3: 

This seems to be working after a couple of hick-up have been resolved.

Closing as done.

Markus Mützel <mmuetzel>
Group administrator
Sun 16 Jul 2023 09:25:14 AM UTC, comment #2: 

Thank you for this diff.

I cross-built Octave on Linux for Windows with this change. And the launcher executable seems to return the exit code from the Octave process now. Tested with `quit(10)` in Octave and `echo $?` at the prompt of the spawning bash.

I didn't notice any unexpected side effects from this change while testing on Windows 11. So, I pushed the change with you as the author to the release branch of MXE Octave here:
https://hg.octave.org/mxe-octave/rev/392c5255d044

It should be part of the next minor release of Octave for Windows.
Additionally, this change should be included in the nightly builds that can be downloaded from here in a couple of days:
https://buildbot.octave.space/#/download

Marking as ready for test.

Btw: No big deal. But it would be better to track this kind of bug on the bug tracker instead of the patch tracker. There are no definitive rules, but the patch tracker is mostly for (larger) new features. The bug tracker is more suitable for minor changes or bug fixes like this one.
(Additionally, the bug tracker sees a bit more traffic by maintainers. But I eventually found your report here, too.)

Markus Mützel <mmuetzel>
Group administrator
Sat 15 Jul 2023 03:04:38 PM UTC, comment #1: 
Vipul Cariappa <vipul_cariappa>
Sat 15 Jul 2023 03:03:15 PM UTC, original submission:  

Presently Octave does not exit with the correct exit code which is supplied to the quit function.

This patch hopes to fix it.

Vipul Cariappa <vipul_cariappa>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #54926:  octave_exit_code.patch added by vipul_cariappa (603B - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by mmuetzel (Posted a comment)
  • -email is unavailable- added by vipul_cariappa (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2023-07-31 mmuetzel StatusReady For Test Done
        Open/ClosedOpen Closed
    2023-07-16 mmuetzel StatusNone Ready For Test
        SummaryFix: Octave exit code does not work on Windows [MXE Octave] Launcher doesn't return Octave's exit code on Windows
    2023-07-15 vipul_cariappa Attached File- Added octave_exit_code.patch, #54926

    Back to the top

    Powered by Savane 3.13-4b48.
    Corresponding source code