patchGNU Octave - Patches: patch #10236, interpreter: Constant literal...

 
 

patch #10236: interpreter: Constant literal type_id

Submitter:  John W. Eaton <jwe>
Submitted:  Wed 22 Jun 2022 01:46:23 PM UTC
   
 
Category:  Core : other Priority:  5 - Normal
Status:  None Privacy:  Public
Assigned to:  None Open/Closed:  Open
* Mandatory Fields

Add a New Comment Rich Markup
   

Thu 02 Mar 2023 10:50:40 PM UTC, comment #2: 

I'm looking at this one now.  You don't need to do anything more to try to update the patch.

John W. Eaton <jwe>
Group administrator
Tue 28 Feb 2023 11:53:45 AM UTC, comment #1: 

I tried updating this patch but got a long series of compiler errors. I could not clear it up for two reasons:

  • There was a recent activity to rename static variables foo as s_foo. Are names like s_t_name and s_c_name intended to be static or just string? This breaks some of the macro expansions in the patch.


  • There was also a recent maintenance activity (by me actually) to remove dead code that had been commented out by "#if 0" for years. These included many lines in Range for types other than double. Many of the lines in this patch make similar changes in Range. But it doesn't compile with or without those lines. It's not clear whether the patch intended such definitions to become active or not.


Pls see if you can take a look at the intent behind the code and the patch for the above points.

Arun Giridhar <arungiridhar>
Group Member
Wed 22 Jun 2022 01:46:23 PM UTC, original submission:  

From Petter Tomner <petter>, extracted from the zip file attached to the following comment in the discourse thread "WIP stack VM f\
or Octave": https://octave.discourse.group/t/wip-stack-vm-for-octave/2884/10

Make the type_id for builtin types a constant literal to make
the type_id an immediate constant in the machine code avoiding
pointer dereferencing of t_id.

John W. Eaton <jwe>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #53354:  octave_30618.patch added by jwe (73KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by arungiridhar (Posted a comment)
  • -email is unavailable- added by jwe (Submitted the item)
  • -email is unavailable- added by jwe
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 2 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2022-06-22 jwe Attached File- Added octave_30618.patch, #53354
        Carbon-Copy- Added petter

    Back to the top

    Powered by Savane 3.13-04b1.
    Corresponding source code