patchGNU Octave - Patches: patch #10231, interpreter: checkelement_value in...


patch #10231: interpreter: checkelement_value in Array.h to avoid make_unique

Submitter:  John W. Eaton <jwe>
Submitted:  Wed 22 Jun 2022 01:45:13 PM UTC
Category:  Core : other Priority:  5 - Normal
Status:  None Privacy:  Public
Assigned to:  None Open/Closed:  Open
* Mandatory Fields

Add a New Comment Rich Markup

Tue 28 Feb 2023 11:41:55 AM UTC, comment #1: 

Updated patch attached. This needs patches new_30599 onwards to be applied in sequence first.

(file #54417)

Arun Giridhar <arungiridhar>
Group Member
Wed 22 Jun 2022 01:45:13 PM UTC, original submission:  

From Petter Tomner <petter>, extracted from the zip file attached to the following comment in the discourse thread "WIP stack VM f\
or Octave":

Add checkelement_value to Array to be able to get an element value
without calling make_unique, like const T& operator[](size_t idx),
but this works with non-const Array:s.

Also inline index computations. Benifitial for operator look-up.

Adding branch hint macros OCTAVE_LIKELY and OCTAVE_UNLIKELY,
using __builtin_expect for gcc and clang.

John W. Eaton <jwe>
Group administrator


(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:

Attached Files
file #54417:  new_30613.patch added by arungiridhar (8KiB - text/x-patch)
file #53349:  octave_30613.patch added by jwe (18KiB - text/x-patch)


Depends on the following items: None found

Items that depend on this one: None found


Carbon-Copy List
  • -email is unavailable- added by arungiridhar (Updated the item)
  • -email is unavailable- added by jwe (Submitted the item)
  • -email is unavailable- added by jwe

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.


    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2023-02-28 arungiridhar Attached File- Added new_30613.patch, #54417
    2022-06-22 jwe Attached File- Added octave_30613.patch, #53349
        Carbon-Copy- Added petter

    Back to the top

    Powered by Savane 3.13-b921.
    Corresponding source code