patchGNU Octave - Patches: patch #10193, Added some BIST to m-files

 
 

patch #10193: Added some BIST to m-files

Submitter:  Sarrah Bastawala <sarrah>
Submitted:  Sun 03 Apr 2022 08:50:47 AM UTC
 
Category:  Core : other Priority:  5 - Normal
Status:  None Privacy:  Public
Assigned to:  None Open/Closed:  Open
* Mandatory Fields

Add a New Comment (Rich Markup)
   

Comment Type & Canned Response:
       

 

Mon 04 Apr 2022 08:43:32 AM UTC, comment #2: 

comment #1:

> A BIST shouldn't open visible figures if possible. And it definitely shouldn't leave them hanging around but close them programmatically.
>
> Take a look at the BIST in, e.g., `axes.m` for how to open invisible figures and how to clean up after the test (both for successful and failure result).
>


comment #1:

> A BIST shouldn't open visible figures if possible. And it definitely shouldn't leave them hanging around but close them programmatically.
>
> Take a look at the BIST in, e.g., `axes.m` for how to open invisible figures and how to clean up after the test (both for successful and failure result).
>


comment #1:

> A BIST shouldn't open visible figures if possible. And it definitely shouldn't leave them hanging around but close them programmatically.
>
> Take a look at the BIST in, e.g., `axes.m` for how to open invisible figures and how to clean up after the test (both for successful and failure result).
>

Sarrah Bastawala <sarrah>
Sun 03 Apr 2022 11:35:19 AM UTC, comment #1: 

A BIST shouldn't open visible figures if possible. And it definitely shouldn't leave them hanging around but close them programmatically.

Take a look at the BIST in, e.g., `axes.m` for how to open invisible figures and how to clean up after the test (both for successful and failure result).

Markus M├╝tzel <mmuetzel>
Project Member
Sun 03 Apr 2022 08:50:47 AM UTC, original submission:  

Here, I saw the hdl2struct file had no tests so far and added a few to check for input validation. There are also other errors in the function that could have tests for them but it says the code is unreachable, hence looking for guidance on hwothese tests can be improved.

Sarrah Bastawala <sarrah>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #53040:  hdl2structTests.patch added by sarrah (1KiB - text/x-patch - Thanks for the pointers, tried to make the required changes, do have a look)
file #53037:  hdl2structTests.patch added by sarrah (1KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by mmuetzel (Posted a comment)
  • -email is unavailable- added by sarrah (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

     

     

     

    Follow 2 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2022-04-03 sarrah Attached File- Added hdl2structTests.patch, #53040
    2022-04-03 sarrah Attached File- Added hdl2structTests.patch, #53037

    Back to the top


    Powered by Savane 3.9