patchGNU Octave - Patches: patch #10062, BIST for winter

 
 

patch #10062: BIST for winter

Submitter:  None
Submitted:  Sat 01 May 2021 08:33:35 AM UTC
 
Category:  Core : other Priority:  5 - Normal
Status:  None Privacy:  Public
Assigned to:  None Originator Email:  -email is unavailable-
Open/Closed:  Open
* Mandatory Fields

Add a New Comment (Rich Markup)
   

Comment Type & Canned Response:
       

 

Sun 02 May 2021 04:22:38 PM UTC, comment #5: 

ML does not allow floats, etc.

Old versions of Octave do.
New version of Octave gives errors.
Patch informs these errors.

How did you create it?

diff -u

New version done with:

hg clone https://www.octave.org/hg/octave
cp ~/octave/winter.m octave/scripts/image/.
hg -diff winter >winter3.patch

(file #51358)

Anonymous
Sun 02 May 2021 03:06:20 PM UTC, comment #4: 

Re comment #2: Which version of Octave do you use?

Fwiw, with Matlab R2021a:

>> winter(2.5)
Error using zeros
Size inputs must be integers.

Error in winter (line 27)
c = [zeros(m,1) r .5+(1-r)/2];

>> winter(2.5+3i)
Warning: Colon operands must be real scalars.
> In winter (line 26)

Error using zeros
Size vector must be a row vector with real elements.

Error in winter (line 27)
c = [zeros(m,1) r .5+(1-r)/2];

>>

So the behavior we currently have in Octave seems to be compatible.

Markus Mützel <mmuetzel>
Project Member
Sun 02 May 2021 01:11:21 PM UTC, comment #3: 

Your patch doesn't apply to the repository?
How did you create it?

Markus Mützel <mmuetzel>
Project Member
Sat 01 May 2021 09:23:39 PM UTC, comment #2: 

Image to show it working.

New version requires integer.

file #51352)

Anonymous
Sat 01 May 2021 06:19:32 PM UTC, comment #1: 

AFAICS the patch actually removes the tests ... (diff'ed in the wrong direction?)
Changing the '-' into'+' fixes that :-)

More serious is this:

:
***** test
 assert (winter (2.5), [0 0 1; 0 0.66667 0.66667], 1e-5)
!!!!! test failed
conversion of 2.5 to int64_t value failed

## (after commenting that out, the next test fails as well:)
>> test winter
:
***** test
 assert (winter(2.5+3i), [0 0 1; 0 0.13333 - 0.26667i 0.93333 + 0.13333i], 1e-5)
!!!!! test failed
conversion of 2.5 to int64_t value failed

(with Octave-7.0.0  dev version)

Philip Nienhuis <philipnienhuis>
Project Member
Sat 01 May 2021 08:33:35 AM UTC, original submission:  

Added tests

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #51358:  winter3.patch added by None (1KiB - text/x-patch - made using hg)
file #51351:  winter_test.png added by None (21KiB - image/png)
file #51352:  winter2.patch added by None (1KiB - text/x-patch)
file #51348:  winter.patch added by None (460B - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by mmuetzel (Posted a comment)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

     

     

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2021-05-02 None Attached File- Added winter3.patch, #51358
    2021-05-01 None Attached File- Added winter_test.png, #51351
        Attached File- Added winter2.patch, #51352
    2021-05-01 None Attached File- Added winter.patch, #51348

    Back to the top


    Powered by Savane 3.9