patchGNU Octave - Patches: patch #9998, C++ Implementation of...

 
 

patch #9998: C++ Implementation of matlab.lang.makeValidName

Submitter:  Kai Torben Ohlhus <siko1056>
Submitted:  Fri 20 Nov 2020 06:38:56 AM UTC
   
 
Category:  Core : other Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  siko1056 Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Tue 24 Nov 2020 02:01:19 PM UTC, comment #4: 

Thanks Markus.

Kai Torben Ohlhus <siko1056>
Group Member
Tue 24 Nov 2020 01:16:29 PM UTC, comment #3: 

I pushed a changeset with minor style changes here:
https://hg.savannah.gnu.org/hgweb/octave/rev/d09dde091073

Markus Mützel <mmuetzel>
Group administrator
Mon 23 Nov 2020 07:17:50 AM UTC, comment #2: 

Thanks for the feedback Markus, I tried to include as much as I understood, feel free to make further modifications.

Pushed to Octave 7 (default):

https://hg.savannah.gnu.org/hgweb/octave/rev/b924b916dc91
https://hg.savannah.gnu.org/hgweb/octave/rev/38e22065d9ec

Kai Torben Ohlhus <siko1056>
Group Member
Fri 20 Nov 2020 05:51:30 PM UTC, comment #1: 

I haven't tested the patches yet. But some nitpicky remarks regarding the style:

  • Indentation of "{ }" blocks seems to be off sometimes.
  • Spaces at lambda expressions should be like in "[] (arg1, arg2) { body; }".
  • Lines shouldn't end with an opening bracket.
  • Class members should start with "m_".
Markus Mützel <mmuetzel>
Group administrator
Fri 20 Nov 2020 06:38:56 AM UTC, original submission:  

Just to avoid loss and maybe as RFC.  I am going to push this on Monday after polishing the patch.

This re implementation finally makes jsondecode faster than Matlab's and Abdallah's GSoC work a full success =)

https://siko1056.github.io/blog/2020/08/19/gsoc2020-json-benchmark.html

Kai Torben Ohlhus <siko1056>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #50307:  jsondecode.patch added by siko1056 (4KiB - text/x-patch)
file #50306:  makeValidName.patch added by siko1056 (13KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by mmuetzel (Posted a comment)
  • -email is unavailable- added by siko1056 (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2020-11-23 siko1056 StatusIn Progress Done
        Open/ClosedOpen Closed
    2020-11-20 siko1056 Attached File- Added jsondecode.patch, #50307
    2020-11-20 siko1056 Attached File- Added makeValidName.patch, #50306

    Back to the top

    Powered by Savane 3.13-caa5.
    Corresponding source code