patchGNU Octave - Patches: patch #9923, [octave forge] (mapping) NED...

 
 

patch #9923: [octave forge] (mapping) NED transformations

Submitter:  None
Submitted:  Sun 19 Apr 2020 08:09:53 PM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  philipnienhuis Originator Email:  -email is unavailable-
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Wed 22 Apr 2020 08:18:58 PM UTC, comment #4: 

After some minor (good!) edits I've pushed the lot here:
http://hg.code.sf.net/p/octave/mapping/rev/1bfa2b8b98ac
http://hg.code.sf.net/p/octave/mapping/rev/6de1c84ae44e
http://hg.code.sf.net/p/octave/mapping/rev/4130878d531f
http://hg.code.sf.net/p/octave/mapping/rev/a438da4df6d4

Thanks for the contributions.

About your question in comment 30;
map.geodesy.isDegree looks like a classdef function, not a struct. Java methods are called similarly using dot notation.

Philip Nienhuis <philipnienhuis>
Group Member
Tue 21 Apr 2020 03:51:43 PM UTC, comment #3: 

Perfect!

so the diff is merely about nitty-gritty. Good, I'll evaluate it.

Philip Nienhuis <philipnienhuis>
Group Member
Tue 21 Apr 2020 07:14:42 AM UTC, comment #2: 

I think I made a changeset.

I did

hg diff -r9651fe inst/ >change.txt


Is this the correct method?

(file #48892)

Anonymous
Mon 20 Apr 2020 08:37:19 PM UTC, comment #1: 

Thanks, you manage to keep my production line saturated quite well :-)

About the diffs, what are they meant to accomplish?
Anyway I can't use them as they stand, please make diffs with "diff -u", that way we get s/th that is easier to import using Mercurial.
Or still better, submit a complete Mercurial changeset.

Philip Nienhuis <philipnienhuis>
Group Member
Sun 19 Apr 2020 08:09:53 PM UTC, original submission:  

New functions:
NED2*
*2NED
departure

Diffs for minor fixes

---
Function map.geodesy.isDegree , is

if (! ischar (angleUnit) || ! ismember (lower (angleUnit(1)), {"d", "r"}))
    error ("map.geodesy.isDegree: angleUnit should be one of 'degrees' or 'radians'")
endif
if (ismember (lower (angleUnit(1)), {"d"}))
   return 1;
endif


How can a structure be a function?

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #48892:  change.txt added by None (4KiB - text/plain)
file #48875:  departure.m added by None (5KiB - text/x-objcsrc)
file #48876:  NED.zip added by None (14KiB - application/zip)
file #48877:  diffs.zip added by None (948B - application/zip)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by siko1056 (Updated the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 10 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2021-04-28 siko1056 Summary[octave forge](mapping) NED transformations [octave forge] (mapping) NED transformations
    2020-04-22 philipnienhuis StatusIn Progress Done
        Open/ClosedOpen Closed
    2020-04-21 philipnienhuis StatusNone In Progress
        Assigned toNone philipnienhuis
    2020-04-21 None Attached File- Added change.txt, #48892
    2020-04-20 philipnienhuis Summary[octave forge](mapping) NED transforations [octave forge](mapping) NED transformations
    2020-04-19 None Attached File- Added departure.m, #48875
        Attached File- Added NED.zip, #48876
        Attached File- Added diffs.zip, #48877

    Back to the top

    Powered by Savane 3.13-caa5.
    Corresponding source code