patchGNU Octave - Patches: patch #9897, Implement the missing ordqz...

 
 

patch #9897: Implement the missing ordqz function.

Submitted by:  Martin K <grisu86>
Submitted on:  Tue 25 Feb 2020 10:01:44 AM UTC  
 
Category:  Core : new function Priority:  5 - Normal
Status:  None Privacy:  Public
Assigned to:  None Open/Closed:  Open

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

( Jump to the original submission)

Sun 14 Jun 2020 11:00:58 AM UTC, comment #6: 

Status to "ready for test".

Philip Nienhuis <philipnienhuis>
Project Member
Sun 14 Jun 2020 10:57:57 AM UTC, comment #5: 

@Martin:
Sorry I missed your update, I wasn't in the cc list. AFAIK that used to automatically add commenter's emails.
Sorry for that :-)

I'm just starting a new Octave 7.0.0 "local" build ("local" in the sense that I include several local mods and path trials) so I'll try your patch as well. After the Linux build I'll make an mxe-octave crossbuild to further try on Windows (where I use Octave the most).

Philip Nienhuis <philipnienhuis>
Project Member
Fri 24 Apr 2020 10:42:30 AM UTC, comment #4: 

I found the bug and added a new test to cover this as well.

The reason was around line 440:

 if ( k < nn-1 && aa(k+1,k) == 0.0 )

where for k == n-1 it was automatically assumed that the corresponding eigenvalue is complex, which is not true in general. I changed it to

 if ( ( k < nn-1 && aa(k+1,k) == 0.0 ) ) || k == nn-1 )

Then everything works and with enabled sanitizer no problems occur.

The fixed patch is attached.

(file #48923)

Martin K <grisu86>
Thu 23 Apr 2020 05:17:22 PM UTC, comment #3: 

Same on Linux, hard crash.

Status -> bug

Philip Nienhuis <philipnienhuis>
Project Member
Thu 23 Apr 2020 05:12:05 PM UTC, comment #2: 

On Windows, reference BLAS or OpenBLAS makes no difference.

I suppose this patch will make it in Octave-7.0.0 at the earliest so it should run fine in dev Octave.

Philip Nienhuis <philipnienhuis>
Project Member
Thu 23 Apr 2020 04:34:20 PM UTC, comment #1: 

Thanks for the patch.
I've included in my mxe-octave builds for a while but only now got round to testing it.

I tried the example here:
https://nl.mathworks.com/help/matlab/ref/ordqz.html

All goes well until the actual call to ordqz, and then Octave-7.0.0 crashes and vanishes w/o a trace. It must be quite a serious one so that even Windows can't catch it with its "program has crashed" dialog.
So no joy:-(

Late tonight I'll try Linux as well.

Philip Nienhuis <philipnienhuis>
Project Member
Tue 25 Feb 2020 10:01:44 AM UTC, original submission:  

I implemented the ordqz function which is still missing in Octave. Until now, Octave says that it is not implemented yet. The function follows the calling sequence of its MATLAB counterpart but also allows the keywords used by the reordering functionallity of Octave's qz function. The patch includes documentation and a set of software tests. The reordering works for real and complex data using the {D,Z}TGSEN function of LAPACK.

Martin K <grisu86>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #48923:  octave-ordqz-fixed.diff added by grisu86 (27KiB - text/x-patch)
file #48496:  octave-ordqz.patch added by grisu86 (25KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by philipnienhuis
  • -email is unavailable- added by grisu86 (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2020-07-11 mtmiller StatusReady For Test => None
    2020-06-14 philipnienhuis StatusBug => Ready For Test
    2020-06-14 philipnienhuis Carbon-Copy- => Added philipnienhuis
    2020-04-24 grisu86 Attached File- => Added octave-ordqz-fixed.diff, #48923
    2020-04-23 philipnienhuis StatusNone => Bug
    2020-02-25 grisu86 Attached File- => Added octave-ordqz.patch, #48496

    Back to the top


    Powered by Savane 3.5