patchGNU Octave - Patches: patch #9888, [octave forge] (linear-algebra)...

 
 

patch #9888: [octave forge] (linear-algebra) Add exp, log and sqrt matrix function to funm

Submitted by:  José Matos <jamatos>
Submitted on:  Tue 28 Jan 2020 06:22:45 PM UTC  
 
Category:  Forge : new feature Priority:  5 - Normal
Status:  None Privacy:  Public
Assigned to:  None Open/Closed:  Open

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue 28 Jan 2020 06:22:45 PM UTC, original submission:  

When using `funm` from linear-algebra package I have noticed a small incompatibility with the corresponding matlab function.

`funm` does not accept as argument the functions `exp`, `log` and `sqrt`.

The reason for that is described in the function's documentation:

## Note that you should not use funm for 'sqrt', 'log' or 'exp'; instead
## use sqrtm, logm and expm as these are more robust.

Yet reading the code this seems to be an outdated comment because if we add them to the set of supported functions then funm will delegate its evaluation to the `thfm` function that supports them (by calling the corresponding sqrtm, logm and expm functions).

So, at least for compatibility, I suggest to add those three functions to the set of supported function since funm already does the right thing and thus I also suggest to remove that comment from the documentation.

I send an attached patch with the proposed trivial changes.

José Matos <jamatos>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #48297:  linear-algebra.diff added by jamatos (840B - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jamatos (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2020-01-28 mtmiller CategoryNone => Forge : new feature
        SummaryAdd exp, log and sqrt matrix function to funm from linear-algebra package => [octave forge] (linear-algebra) Add exp, log and sqrt matrix function to funm
    2020-01-28 jamatos Attached File- => Added linear-algebra.diff, #48297

    Back to the top


    Powered by Savane 3.5