patchPSPP - Patches: patch #9777, Added gui support for some POSTHOC...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #9777: Added gui support for some POSTHOC tests for One Way ANOVA

Submitted by:  Ayhan Yalçınsoy <ayhanyalcinsoy>
Submitted on:  Thu 21 Mar 2019 08:08:30 AM UTC  
 
Category:  None Item Group:  None
Status:  Done Assigned to:  None
Open/Closed:  Closed

( Jump to the original submission)

Tue 16 Apr 2019 05:22:24 PM UTC, comment #12:

Thanks for this.

There were a still a few minor problems but I fixed these and committed your patch.

Thanks once again for doing this work.

John Darrington <jmd>
Project Administrator
Tue 16 Apr 2019 03:03:06 PM UTC, comment #11:

Hi John,
1. Now posthoc dialog Cancel button is run.
2. Unneeded lines was removed.
3. Posthoc conditions were sperated and output is following.
ONEWAY
ONEWAY/VARIABLES = IAN BY calismasuresi
/STATISTIC = DESCRIPTIES
HOMOGENEITY
/POSTHOC = BONFERRONI GH LSD
SCHEFFE SIDAK TUKEY .
4. Posthoc tests are listing like /POSTHOC = GH SIDAK BONFERRONI.

Thanks for your advice. They improve me.

(file #46780)

Ayhan Yalçınsoy <ayhanyalcinsoy>
Mon 15 Apr 2019 03:55:57 PM UTC, comment #10:

Thanks for the update. This looks much better. But unfortunately there are still a couple of issues, and it's to do with the generate_syntax function.

1. In the posthoc dialog, if I select some posthoc options and then click Cancel, the effect of the Cancel button is ignored.

All these lines should be deleted :

gboolean bonferroni = gtk_toggle_button_get_active (GTK_TOGGLE_BUTTON (ow->bonferroni_button));
gboolean gh = gtk_toggle_button_get_active (GTK_TOGGLE_BUTTON (ow->gh_button));
...

and instead the of writing

if (lsd)
ds_put_cstr (&dss, "\n\t/POSTHOC=LSD ");

it should be similar to

if (ow->posthoc & POSTHOC_LSD)
ds_put_cstr (&dss, "\n\t/POSTHOC=LSD ");

2. If I select some posthoc options, but no Statistics options, then I get the syntax:

ONEWAY /VARIABLES= v1 BY v2
/STATISTICS=
/POSTHOC=GH
/POSTHOC=SIDAK .

which is invalid. So you need to change the conditional block

if (descriptives || homogeneity || bonferroni || gh || lsd || scheffe || sidak || tukey)
{
...

into two separate conditions, one for the statistics, and another for the posthoc tests.

3. I think it's more concise if rather than

/POSTHOC=GH
/POSTHOC=SIDAK
/POSTHOC=BONFERRONI.

you arrange for the syntax to be generated as:

/POSTHOC = GH SIDAK BONFERRONI.

I hope this makes sense.

John Darrington <jmd>
Project Administrator
Mon 15 Apr 2019 07:35:40 AM UTC, comment #9:

And here is fixed patch.

(file #46775)

Ayhan Yalçınsoy <ayhanyalcinsoy>
Mon 15 Apr 2019 06:55:27 AM UTC, comment #8:

Hi John,

I fixed patch according to your advice. Here is screenshot https://www.turko.men/wp-content/uploads/2019/04/new_posthoc.png

Ayhan Yalçınsoy <ayhanyalcinsoy>
Fri 12 Apr 2019 06:46:21 PM UTC, comment #7:

John thanks for your advices. I will send new patch after fix problems.

Ayhan Yalçınsoy <ayhanyalcinsoy>
Fri 12 Apr 2019 06:36:42 PM UTC, comment #6:

Sorry for the confusion. Hopefully I'm looking at the right patch
now. There are a few issues with it:

1. These macros:

#define POSTHOC_BONFERRONI 0x01
#define POSTHOC_GH 0x02
#define POSTHOC_LSD 0x03
#define POSTHOC_SCHEFFE 0x04
#define POSTHOC_SIDAK 0x05
#define POSTHOC_TUKEY 0x06

You are using as bit fields, but you have defined their values as
sequential integers. You must define them as unique bit values
otherwise they will interfere with each other.

2. In the GUI, you have put all the options in upper case. It looks
better to write "Tukey HSD" rather than "TUKEY HSD". Also please
make sure that the diacritics are correct
(refer to https://en.wikipedia.org/w/index.php?title=Sidak_correction and
https://en.wikipedia.org/w/index.php?title=Scheffe_method)

3. Do you think the Contrasts and PostHoc buttons would be better
packed vertically rather than horizontally?

4. Minor nit:

Comments like /*Posthoc button */ should normally be written with a
space, like /* Posthoc button */

Perhaps you could make these corrections and send a new patch.

Thanks

John Darrington <jmd>
Project Administrator
Thu 11 Apr 2019 08:26:50 PM UTC, comment #5:

This patch creates posthoc own submenu like screenshoot https://savannah.gnu.org/patch/download.php?file_id=46633

Ayhan Yalçınsoy <ayhanyalcinsoy>
Thu 11 Apr 2019 07:43:00 PM UTC, comment #4:

I think you want to say like at https://savannah.gnu.org/patch/download.php?file_id=46634 . Like this would be better.

Ayhan Yalçınsoy <ayhanyalcinsoy>
Thu 11 Apr 2019 05:26:37 PM UTC, comment #3:

Perhaps this would be better if the Posthoc tests had their own submenu (much like the Contrasts submenu).

What do you think?

John Darrington <jmd>
Project Administrator
Mon 25 Mar 2019 07:59:09 AM UTC, comment #2:

I changed code again. I added a button (Post-Hoc) One Way ANOVA dialog when click it opens a dialog inclue a posthoc test list. You can easy choose you want to use test.

Ayhan Yalçınsoy <ayhanyalcinsoy>
Thu 21 Mar 2019 05:55:33 PM UTC, comment #1:

This patch looks fine to me.

I think it's slightly too long to be considered legally insignificant, so in order to include this code, we'll have to get a copyright assignment from you.

Are you ok with that?

John Darrington <jmd>
Project Administrator
Thu 21 Mar 2019 08:08:30 AM UTC, original submission:

We already can't use GUI for POSTHOC tests. This patch added this features to PSPP. I hope developer will add it into source code.

Ayhan Yalçınsoy <ayhanyalcinsoy>

 

Attached Files
file #46780:  posthoc_last.patch added by ayhanyalcinsoy (17KiB - text/x-patch)
file #46775:  posthoc_last.patch added by ayhanyalcinsoy (17KiB - text/x-patch)
file #46633:  posthoc_stats.patch added by ayhanyalcinsoy (17KiB - text/x-patch - added new posthoc tests and posthoc dialog.)
file #46634:  anaova_gui.png added by ayhanyalcinsoy (52KiB - image/png - added new posthoc tests and posthoc dialog.)
file #46598:  add_posthoc_gui.patch added by ayhanyalcinsoy (6KiB - text/x-patch - This patch runs without any problem)
file #46599:  posthoc_tests.png added by ayhanyalcinsoy (21KiB - image/png - This patch runs without any problem)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jmd (Posted a comment)
  • -email is unavailable- added by ayhanyalcinsoy (Submitted the item)
  • -email is unavailable- added by ayhanyalcinsoy
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 13 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2019-04-20 jmd Open/ClosedOpen => Closed
    2019-04-16 jmd StatusIn Progress => Done
    2019-04-16 ayhanyalcinsoy Attached File- => Added posthoc_last.patch, #46780
    2019-04-15 ayhanyalcinsoy Attached File- => Added posthoc_last.patch, #46775
    2019-04-12 jmd StatusNone => In Progress
    2019-04-11 jmd Carbon-CopyRemoved -email is unavailable- => -
    2019-03-25 ayhanyalcinsoy Attached File- => Added posthoc_stats.patch, #46633
        Attached File- => Added anaova_gui.png, #46634
    2019-03-21 ayhanyalcinsoy Attached File- => Added add_posthoc_gui.patch, #46598
        Attached File- => Added posthoc_tests.png, #46599
    2019-03-21 ayhanyalcinsoy Attached File- => Added add_posthoc_gui.patch, #46597
        Carbon-Copy- => Added -email is unavailable-
        Carbon-Copy- => Added -email is unavailable-

    Back to the top


    Powered by Savane 3.4