patchGNU Octave - Patches: patch #9743, [octave forge] (statistics)...

 
 

patch #9743: [octave forge] (statistics) silhouette function

Submitted by:  None
Submitted on:  Tue 08 Jan 2019 03:11:58 PM UTC  
 
Category:  Forge : new function Priority:  5 - Normal
Status:  None Privacy:  Public
Assigned to:  None Originator Email:  -email is unavailable-
Open/Closed:  Open

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sun 13 Jan 2019 07:48:01 PM UTC, comment #1: 

Thank you for this contribution. Very good Octave coding style.

A quick look shows that it needs some work:

  • It needs tests
  • The nested functions had better be moved outside the main function

Then still some nitpicking (apologies!) as regards Octave coding style:
- endfunction rather than end
- start comment lines with ## rather than %
- texinfo header rather than plain text
- space between function names and their arguments
For examples take about any .m-file function from the statistics package.

Philip Nienhuis <philipnienhuis>
Project Member
Tue 08 Jan 2019 03:11:58 PM UTC, original submission:  

perhaps we can integrate this?
https://github.com/solo7773/silhouette_Octave

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

 

 

Follows 1 latest change.

Date Changed by Updated Field Previous Value => Replaced by
2019-01-08 mtmiller Summary[octave-forge statistics] silhouette function => [octave forge] (statistics) silhouette function

Back to the top


Powered by Savane 3.5