patchGNU Octave - Patches: patch #9741, Compile the JIT with LLVM 3.9

 
 

patch #9741: Compile the JIT with LLVM 3.9

Submitted by:  Julien Bect <jbect>
Submitted on:  Thu 03 Jan 2019 09:15:04 AM UTC  
 
Category:  Core : other Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  None Open/Closed:  Closed

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 14 Jan 2019 06:15:05 AM UTC, comment #5: 

Great.  Thank you.

Here is a tiny patch that fixes a typo in pt-jit.cc.

(file #45966)

Julien Bect <jbect>
Mon 14 Jan 2019 03:42:07 AM UTC, comment #4: 

I pushed all your patches to stable in time for the 5.0 release.  Thanks for the hard work here.

Rik <rik5>
Project Administrator
Sat 05 Jan 2019 10:31:10 AM UTC, comment #3: 

Here is a better series of patches, which also fixes one incompatibliy with LLVM 3.6, improves the "checking..." configure messages, and starts to clean up a little bit the public API.

To be applied on default.

Ths first patches are the same as earlier, so you just have to apply this one, not both of them.

(file #45873)

Julien Bect <jbect>
Fri 04 Jan 2019 10:12:53 AM UTC, comment #2: 

@Mike: I don't know how much time I would be able to put in this in the near future, but in any case this is as you say a separate issue, I have opened a bug report for it (https://savannah.gnu.org/bugs/index.php?55382).

Julien Bect <jbect>
Fri 04 Jan 2019 12:10:48 AM UTC, comment #1: 

Hi, if you are interested in improving Octave's compatibility with LLVM, would you also be interested in working on removing all HAVE_LLVM conditionals from Octave's public header files? It is bad form to have a public API that varies depending on how Octave was compiled or requires the user to define the same HAVE_LLVM macros when using the API. Subject of a separate task or project, just pointing it out in case you are interested.

Mike Miller <mtmiller>
Project Administrator
Thu 03 Jan 2019 09:15:04 AM UTC, original submission:  

Currently, on default, --enable-jit can only be used with LLVM 3.8.

This series of patches make it possible to build with LLVM 3.7, 3.8, 3.9 and 4.0.

With 3.9 the unit tests pass as with 3.8: 36/38 pass, 2 xtests.

With 4.0 one of the unit tests crashes Octave, but some basic loops can still be successfully compiled by the JIT.

With 3.7 not only do the unit tests crash Octave, but even a very simple loop crashes it.

In any case, the situation is better IMHO with theses patches than without them, so propose to apply them on default.

Julien Bect <jbect>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #45966:  pt-jit-typo.patch added by jbect (826B - text/x-patch)
file #45873:  Octave-LLVM-39-v2.zip added by jbect (9KiB - application/zip)
file #45849:  octave-LLVM-3.9.zip added by jbect (6KiB - application/zip)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rik5 (Posted a comment)
  • -email is unavailable- added by jbect (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2019-01-14 jbect Attached File- => Added pt-jit-typo.patch, #45966
    2019-01-14 rik5 StatusNone => Done
        Open/ClosedOpen => Closed
    2019-01-05 jbect Attached File- => Added Octave-LLVM-39-v2.zip, #45873
    2019-01-03 jbect Attached File- => Added octave-LLVM-3.9.zip, #45849

    Back to the top


    Powered by Savane 3.5