patchGNU Octave - Patches: patch #9698, [octave forge] (signal) new...

 
 

patch #9698: [octave forge] (signal) new function vco

Submitted by:  John W. Eaton <jwe>
Submitted on:  Wed 10 Oct 2018 01:27:05 PM UTC  
 
Category:  Forge : new function Priority:  5 - Normal
Status:  In Progress Privacy:  Public
Assigned to:  None Open/Closed:  Open

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

( Jump to the original submission)

Fri 08 Mar 2019 07:01:20 PM UTC, comment #8: 

The latest looks fine to me, but it's missing a copyright header, doc string, and tests.

I've effectively made signal 1.4.1 so I'm open to adding new functions now.

Mike Miller <mtmiller>
Project Administrator
Mon 04 Mar 2019 08:23:01 PM UTC, comment #7: 

Oops, forgot to attach before submitting...

Also, this version no longer calls modulate, though I think it would be possible to do so.  I'll leave it up to you to decide whether we should or not.

(file #46419)

John W. Eaton <jwe>
Project Administrator
Mon 04 Mar 2019 08:21:38 PM UTC, comment #6: 

I'm attaching a new version that attempts to implement FMIN and FMAX (as elements of FC).

John W. Eaton <jwe>
Project Administrator
Wed 09 Jan 2019 09:57:40 PM UTC, comment #5: 

I'm also attaching a copy of the modulate function here that was written by P Sudeepam.

Mike: what needs to be done to include these functions in the signal package?

(file #45921)

John W. Eaton <jwe>
Project Administrator
Thu 11 Oct 2018 09:33:27 PM UTC, comment #4: 

I'm attaching a new version that calls modulate to do the real work.  I also need some help understanding exactly what the FMIN and FMAX parameters are supposed to do.

(file #45184)

John W. Eaton <jwe>
Project Administrator
Thu 11 Oct 2018 06:10:42 PM UTC, comment #3: 

Yes, it should be simple to make this function use modulate.

John W. Eaton <jwe>
Project Administrator
Wed 10 Oct 2018 04:46:42 PM UTC, comment #2: 

Do you want to look at rewriting this to use the latest revision of modulate and help test it that way? I haven't reviewed or tested it yet, but these could go in together.

Mike Miller <mtmiller>
Project Administrator
Wed 10 Oct 2018 01:30:15 PM UTC, comment #1: 

If Octave had a modulate function, then vco could use it.

It only occurred to me to search for a patch to provide the modulate function after adding this function here.  It turns out there is one in patch #9409.

John W. Eaton <jwe>
Project Administrator
Wed 10 Oct 2018 01:27:05 PM UTC, original submission:  

I noticed that the function vco was missing.  Here's an initial implementation.  It still needs a doc string.  Comments and suggestions welcome.

John W. Eaton <jwe>
Project Administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #46419:  vco.m added by jwe (2KiB - text/x-objcsrc)
file #45921:  modulate.m-2019-01-09 added by jwe (7KiB - application/octet-stream)
file #45184:  vco.m-2018-10-11 added by jwe (1KiB - application/octet-stream)
file #45177:  vco.m-2018-10-10 added by jwe (1KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jwe (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2019-03-04 jwe Attached File- => Added vco.m, #46419
    2019-01-09 jwe Attached File- => Added modulate.m-2019-01-09, #45921
    2018-10-11 jwe Attached File- => Added vco.m-2018-10-11, #45184
    2018-10-10 jwe Attached File- => Added vco.m-2018-10-10, #45177

    Back to the top


    Powered by Savane 3.5