patchGNU Octave - Patches: patch #9432, [octave-forge] (gsl) Add function...

 
 

patch #9432: [octave-forge] (gsl) Add function gsl_ran_landau_pdf

Submitted by:  Mathieu Trocmé <mtrocme>
Submitted on:  Wed 09 Aug 2017 08:47:51 AM UTC  
 
Category: Forge : otherPriority: 5 - Normal
Status: Need InfoPrivacy: Public
Assigned to: NoneOpen/Closed: Open

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Fri 18 Aug 2017 08:04:54 AM UTC, comment #1:

The problem is easy to see if you build step by step.

First, if you just try to bootstrap with your patch:

you get the following error:

The proper template to use would have been D_D since the function you're interested in takes one double input and returns one double output.

If I simply fix that, I get another (more severe) problem at the make step.

fails with:

This is because all the templates that are currently available expect the signature of the gsl_sf_*_e functions, i.e., an int return type for the error code and a final gsl_sf_result argument for the double return value.

If you want to add gsl_ran_landau_pdf to the gsl package, you must either write a new kind of template, or wrap the gsl_ran_landau_pdf function inside an gsl_ran_landau_pdf_e function to make it look like the others.

Julien Bect <jbect>
Wed 09 Aug 2017 08:47:51 AM UTC, original submission:

Hi there,

As I understood it, any gsl functions can be added to Octave through the octave-gsl wrapper
https://sourceforge.net/p/octave/gsl/ci/1.0.8/tree/src/README

Here's the unsuccessful attempt I made
http://octave.1599824.n4.nabble.com/gsl-ran-landau-pdf-in-octave-gsl-td4684319.html
And attached are the corresponding changes.

I feel I'm just missing something...

Thanks for your help,
Mathieu

Mathieu Trocmé <mtrocme>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #41458:  buildgsl_sf.sh.diff added by mtrocme (1KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by siko1056 (Updated the item)
  • -unavailable- added by jbect (Posted a comment)
  • -unavailable- added by mtrocme (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 10 Jan 2018 01:46:22 PM UTCsiko1056StatusNone=>Need Info
      SummaryHow to add new gsl functions to octave?=>[octave-forge] (gsl) Add function gsl_ran_landau_pdf
    Wed 09 Aug 2017 08:47:51 AM UTCmtrocmeAttached File-=>Added buildgsl_sf.sh.diff, #41458

    Back to the top


    Powered by Savane 3.1-cleanup1