patchGNU Octave - Patches: patch #9363, missing movie function

 
 

patch #9363: missing movie function

Submitted by:  Pantxo Diribarne <pantxo>
Submitted on:  Sun 28 May 2017 12:01:36 PM UTC  
 
Category:  Core : new function Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  Pantxo Diribarne <pantxo> Open/Closed:  Closed

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 15 Dec 2018 11:47:47 PM UTC, comment #5:

@Pantxo: After reviewing, I pushed your improved patch here (https://hg.savannah.gnu.org/hgweb/octave/rev/2730917a7979).  Thanks a lot, this is a nice addition to Octave.

Rik <rik5>
Project Administrator
Sat 15 Dec 2018 01:12:47 PM UTC, comment #4:

@Rik: I attached a patch in which I fixed the problem of creating a new image for each movie. It also improves input checking and FPS accuracy. 

(file #45674)

Pantxo Diribarne <pantxo>
Project MemberIn charge of this item.
Thu 13 Dec 2018 09:35:33 AM UTC, comment #3:

Sorry, I had started rebasing but forgot to post here. I'll push a cset soon in order to fix some input validation issues (including the one that makes images accumulate) and timing inaccuracies.

Pantxo Diribarne <pantxo>
Project MemberIn charge of this item.
Thu 13 Dec 2018 12:16:06 AM UTC, comment #2:

@Pantxo: I refreshed your patch to apply to the dev branch and pushed it here (https://hg.savannah.gnu.org/hgweb/octave/rev/2be1833a93a5).

I don't know what the expected behavior is, but when I call movie() multiple times it leaves multiple images in the figure object.  Perhaps movie.m should attempt to re-use an existing image, or maybe clear the axes before plotting in to it.  You might see how Matlab behavies on this point.

Rik <rik5>
Project Administrator
Fri 07 Dec 2018 06:26:38 AM UTC, comment #1:

@Pantxo: This patch is old, but do you want to refresh it and check it in before the 5.0 release?

Rik <rik5>
Project Administrator
Sun 28 May 2017 12:01:36 PM UTC, original submission:

I attached an implementation of Matlab's "movie" function.
It currently misses the call form with a "loc" argument.

Pantxo Diribarne <pantxo>
Project MemberIn charge of this item.

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #45674:  movie_timing2.patch added by pantxo (6KiB - text/x-patch)
file #40802:  movie.patch added by pantxo (9KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rik5 (Posted a comment)
  • -email is unavailable- added by pantxo (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-12-15 pantxo Attached File- => Added movie_timing2.patch, #45674
    2018-12-13 rik5 StatusIn Progress => Done
        Open/ClosedOpen => Closed
    2017-05-28 pantxo Attached File- => Added movie.patch, #40802

    Back to the top


    Powered by Savane 3.4