patchGNU Octave - Patches: patch #9302, [octave forge] (mapping) Included...

 
 

patch #9302: [octave forge] (mapping) Included some functions and improved few others.

Submitted by:  Mithil <mithil>
Submitted on:  Sat 25 Mar 2017 08:48:06 AM UTC  
 
Category: Forge : new functionPriority: 3 - Low
Status: PostponedPrivacy: Public
Assigned to: Philip Nienhuis <philipnienhuis>Open/Closed: Open

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Fri 23 Jun 2017 06:58:56 PM UTC, comment #6:

No anwer forovalmost 2,5 months.

Lowering priority & postponed

Philip Nienhuis <philipnienhuis>
Project MemberIn charge of this item.
Wed 29 Mar 2017 06:54:35 PM UTC, comment #5:

Mithil,

Thanks for your contributions.

I took a brief look and noted following:

deg2sm.m & deg2nm.m & rad2nm.m & rad2sm.m:

  • (C) 2013 CarnĂ« Draug ?? (did you copy verbatim from another function? I suppose you as author have the copyright)
  • These functions need tests, also input validation tests. E.g.,
  • The persistent statement had better be in the first lines of the function body
  • Could you please also implement alternative radii of celestial bodies? E.g., sm2deg has them.

earthradius.m:

  • (C) 2017 CarnĂ« Draug ?? see above
  • needs input validation tests (see example above)

Other than that you did a good job of adhering to coding style standards.

Philip Nienhuis <philipnienhuis>
Project MemberIn charge of this item.
Mon 27 Mar 2017 05:25:37 PM UTC, comment #4:

BTW have you uploaded the patches for patch #9301 here also, rather than there? In that case I'll close patch #9301

Philip Nienhuis <philipnienhuis>
Project MemberIn charge of this item.
Mon 27 Mar 2017 05:24:28 PM UTC, comment #3:

Thanks Mithil, I'll take a look.

2nd half of the week I'll have time for this (I hope)

Philip Nienhuis <philipnienhuis>
Project MemberIn charge of this item.
Mon 27 Mar 2017 05:14:31 AM UTC, comment #2:

Thanks for correcting me.

I have now added the required m-script files and the PATCH file. Looking forward to contributing more.

Mithil <mithil>
Sun 26 Mar 2017 08:09:36 AM UTC, comment #1:

Thank you.
Please see my comment at patch #9301.
Mainly upload separate files, not one big thing just called "FILE"

Philip Nienhuis <philipnienhuis>
Project MemberIn charge of this item.
Sat 25 Mar 2017 08:48:06 AM UTC, original submission:
Mithil <mithil>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #40165:  rad2sm.m added by mithil (2KiB - text/x-objcsrc)
file #40161:  earthRadius.m added by mithil (2KiB - text/x-objcsrc)
file #40162:  deg2nm.m added by mithil (2KiB - text/x-objcsrc)
file #40163:  rad2nm.m added by mithil (2KiB - text/x-objcsrc)
file #40164:  deg2sm.m added by mithil (2KiB - text/x-objcsrc)
file #40126:  FILE added by mithil (26KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by siko1056 (Updated the item)
  • -unavailable- added by mithil (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 10 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 08 Oct 2017 01:20:52 PM UTCsiko1056SummaryMapping package. Included some functions and improved few others.=>[octave forge] (mapping) Included some functions and improved few others.
    Fri 23 Jun 2017 06:58:56 PM UTCphilipnienhuisPriority5 - Normal=>3 - Low
      StatusNone=>Postponed
    Mon 27 Mar 2017 05:25:47 PM UTCphilipnienhuisAssigned toNone=>philipnienhuis
    Mon 27 Mar 2017 05:12:00 AM UTCmithilAttached File-=>Added rad2sm.m, #40165
    Mon 27 Mar 2017 05:10:53 AM UTCmithilAttached File-=>Added earthRadius.m, #40161
      Attached File-=>Added deg2nm.m, #40162
      Attached File-=>Added rad2nm.m, #40163
      Attached File-=>Added deg2sm.m, #40164
    Sat 25 Mar 2017 08:48:06 AM UTCmithilAttached File-=>Added FILE, #40126

    Back to the top


    Powered by Savane 3.1-cleanup1