patchGNU Octave - Patches: patch #9265, [octave forge] (signal) isstable:...


patch #9265: [octave forge] (signal) isstable: new function

Submitted by:  -X- <vlefkopo>
Submitted on:  Sun 19 Feb 2017 07:37:32 PM UTC  
Category:  Forge : new function Priority:  5 - Normal
Status:  Need Info Privacy:  Public
Assigned to:  Mike Miller <mtmiller> Open/Closed:  Open

Add a New Comment (Rich Markup)

You are not logged in

Please log in, so followups can be emailed to you.


Mon 05 Apr 2021 05:31:50 AM UTC, comment #2: 

Since this has not been touched.
Improved the docstrings format
Then did the tests

Has something changed?

>> [z,p,g] = butter(6,0.7,'high');
>> sos = zp2sos(z,p,g);
error: cplxpair: could not pair all complex numbers
error: called from
    cplxpair at line 118 column 9
    cplxreal at line 66 column 7
    zp2sos at line 79 column 10

My versions:
octave 4.2.2 (This fits the time of your test)
control 3.1
signal 1.4

Is this a bug or am I doing something wrong?

Fri 30 Mar 2018 08:36:05 PM UTC, comment #1: 

Thank you for your work on this function so far.

The function works for me, looks fairly Matlab compatible, and includes unit tests that all pass. Very good work.

The coding style mostly conforms to the Octave coding style, but could use some small improvements. Octave always includes a space between the function name and the parenthesized argument list. The function doc string should be written in Texinfo format. And some more input validation could be done to ensure the arguments are correct before they are used.

I can help clean some of these things up if you don't have time or interest in working on this. Let me know if you would like to update the function file.

Mike Miller <mtmiller>
Project AdministratorIn charge of this item.
Sun 19 Feb 2017 07:37:32 PM UTC, original submission:  

I implemented the isstable function of the signal package.

Since this is my first time submitting, I would be grateful for any kind of feedback and comments that would benefit my future work and submissions.

-X- <vlefkopo>


(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:

Attached Files
file #39791:  isstable.m added by vlefkopo (2KiB - application/octet-stream)


Depends on the following items: None found

Items that depend on this one: None found


Carbon-Copy List
  • -email is unavailable- added by vlefkopo (Submitted the item)

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.




    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2019-03-07 mtmiller Carbon-CopyRemoved 80942 => -
    2018-03-30 mtmiller StatusNone => Need Info
    2018-03-30 mtmiller Assigned toNone => mtmiller
        Summarysignal package: Implemented isstable function => [octave forge] (signal) isstable: new function
    2017-02-19 vlefkopo Attached File- => Added isstable.m, #39791

    Back to the top

    Powered by Savane 3.6