patchGNU Octave - Patches: patch #9265, [octave forge] (signal) isstable:...

 
 

patch #9265: [octave forge] (signal) isstable: new function

Submitted by:  -X- <vlefkopo>
Submitted on:  Sun 19 Feb 2017 07:37:32 PM UTC  
 
Category: Forge : new functionPriority: 5 - Normal
Status: Need InfoPrivacy: Public
Assigned to: Mike Miller <mtmiller>Open/Closed: Open

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Fri 30 Mar 2018 08:36:05 PM UTC, comment #1:

Thank you for your work on this function so far.

The function works for me, looks fairly Matlab compatible, and includes unit tests that all pass. Very good work.

The coding style mostly conforms to the Octave coding style, but could use some small improvements. Octave always includes a space between the function name and the parenthesized argument list. The function doc string should be written in Texinfo format. And some more input validation could be done to ensure the arguments are correct before they are used.

I can help clean some of these things up if you don't have time or interest in working on this. Let me know if you would like to update the function file.

Mike Miller <mtmiller>
Project AdministratorIn charge of this item.
Sun 19 Feb 2017 07:37:32 PM UTC, original submission:

I implemented the isstable function of the signal package.

Since this is my first time submitting, I would be grateful for any kind of feedback and comments that would benefit my future work and submissions.

-X- <vlefkopo>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #39791:  isstable.m added by vlefkopo (2KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by mtmiller (Updated the item)
  • -unavailable- added by vlefkopo (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 30 Mar 2018 08:36:05 PM UTCmtmillerStatusNone=>Need Info
    Fri 30 Mar 2018 02:07:19 AM UTCmtmillerAssigned toNone=>mtmiller
      Summarysignal package: Implemented isstable function=>[octave forge] (signal) isstable: new function
    Sun 19 Feb 2017 07:37:32 PM UTCvlefkopoAttached File-=>Added isstable.m, #39791

    Back to the top


    Powered by Savane 3.1-cleanup1