patchGNU Octave - Patches: patch #9179, [octave forge] (control) dcgain.m

 
 

patch #9179: [octave forge] (control) dcgain.m

Submitted by:  None
Submitted on:  Wed 30 Nov 2016 04:29:04 PM UTC  
 
Category:  Forge : new function Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  None Originator Email:  -email is unavailable-
Open/Closed:  Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Fri 30 Mar 2018 08:05:13 AM UTC, comment #4:

I added the documentation and tests. This can be closed.

Alexander Wilms <alexanderw>
Fri 30 Mar 2018 05:50:05 AM UTC, comment #3:

Should this be closed as "won't do" since the control package already has @lti/dcgain.m?

Mike Miller <mtmiller>
Project Administrator
Fri 16 Feb 2018 04:11:06 PM UTC, comment #2:

There's already https://sourceforge.net/p/octave/control/ci/default/tree/inst/@lti/dcgain.m

The list of missing functions needs to be updated. Could the only implementation of dcgain automatically be called when no arguments have been supplied (which would call print_usage)?

The existing implementation could reuse the help text and tests of the patch, though.

Alexander Wilms <alexanderw>
Sun 01 Jan 2017 07:52:03 PM UTC, comment #1:

Thank you for the contribution.

I think the documentation is misformatted. Check to see if it all shows up when you type `help dcgain`.

Also, could you add some unit tests to help users verify that the function works?

Nir Krakauer <nir_krakauer>
Wed 30 Nov 2016 04:29:04 PM UTC, original submission:

Implements the dcgain function for the control toolbox.

## Compute the DC gain k of a linear time invariant (LTI) system
##
## Transfer function for a continuous state space system (A,B,C,D)
## G(s) = C * inv(s*I - A) * B + D
##
## DC Gain: evaluate G(s) as s -> 0
## k = C * inv(-A) * B + D
##
## Transfer function for a discrete state space system (A,B,C,D,T)
## G(z) = C * inv(z*I - A) * B + D
##
## DC Gain: evaluate G(z) as z -> 1
## k = C * inv(I-A) * B + D

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #39358:  dcgain.m added by None (2KiB - application/octet-stream - Apologies for the error in formatting the help function. This is now corrected in the attached new version, which also contains three unit tests to confirm correct operation. Geraint)
file #39111:  dcgain.m added by None (2KiB - text/x-objcsrc)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by mtmiller (Posted a comment)
  • -email is unavailable- added by alexanderw (Posted a comment)
  • -email is unavailable- added by nir_krakauer (Posted a comment)
  • -email is unavailable- added by None (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 7 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-03-30 mtmiller StatusWont Do => Done
    2018-03-30 mtmiller StatusNeed Info => Wont Do
        Open/ClosedOpen => Closed
    2018-03-30 mtmiller StatusNone => Need Info
        Summarydcgain.m: control toolbox => [octave forge] (control) dcgain.m
    2017-01-03 None Attached File- => Added dcgain.m, #39358
    2016-11-30 None Attached File- => Added dcgain.m, #39111

    Back to the top


    Powered by Savane 3.3