patchGNU Octave - Patches: patch #9108, improved pcg and gmres from SoCiS...

 
 

patch #9108: improved pcg and gmres from SoCiS 2016

Submitted by:  Marco Caliari <caliari>
Submitted on:  Sun 04 Sep 2016 09:31:44 AM UTC  
 
Category:  Core : other Priority:  5 - Normal
Status:  Ready For Test Privacy:  Public
Assigned to:  Marco Caliari <caliari> Open/Closed:  Open

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

( Jump to the original submission)

Fri 10 Mar 2017 02:30:21 PM UTC, comment #8:

Uploaded a new patch, after changeset 23219 changed copyright dates.

(file #39963)

Marco Caliari <caliari>
Project MemberIn charge of this item.
Wed 01 Feb 2017 11:55:02 AM UTC, comment #7:

Done. I also removed Function file from @deftypefn {}.

(file #39638)

Marco Caliari <caliari>
Project MemberIn charge of this item.
Wed 01 Feb 2017 11:21:47 AM UTC, comment #6:

Marco,

As you are working on it, could you please fix all
the copyright years in the file headers?

The ones in the default branch should be correct, you
need only to add yourself and/or Cristiano, not to change
what is there now.

c.

Carlo de Falco <cdf>
Project Member
Wed 01 Feb 2017 10:35:06 AM UTC, comment #5:

It is a patch to be applied to the default branch. I think you should revert your commit 76a38da in branch dorigo and then apply.

Marco Caliari <caliari>
Project MemberIn charge of this item.
Wed 01 Feb 2017 10:17:51 AM UTC, comment #4:

Marco,

How did you create this patch?
Can I import it into the BitBucket repository?

c.

Carlo de Falco <cdf>
Project Member
Wed 01 Feb 2017 09:26:49 AM UTC, comment #3:

Dear all, I worked on Cristiano's patch, too. It now applies without any problem. I reverted 22765 (tol -> rtol), since the tolerance is always meant to be relative and always called tol (in Matlab, too). I fixed some documentation problems (@ -> @@) and added an entry in linalg.txi. All the codes now work with class single, too. If there still are systematic style or other problems, please tell me, I will fix them.

(file #39637)

Marco Caliari <caliari>
Project MemberIn charge of this item.
Tue 29 Nov 2016 02:51:22 PM UTC, comment #2:

Hi,

I have been keeping this code up to date in a
mercurial repository hosted here:
https://bitbucket.org/cdf1/octave/branch/dorigo

The patch attached ( file #39099 )
is obtained by issuing the command

on that repository.

I'd like to push this as soon as possible
before too many changes are made in core
and keeping up to date becomes too difficult.

Indeed there are a few issues that are immediately
apparent, e.g. this changeset reverts the update
of copyright notices that was done prior to the release
of 4.2, but I'd rather push to core and continue
working there if possible.

(file #39100)

Carlo de Falco <cdf>
Project Member
Tue 29 Nov 2016 02:33:05 PM UTC, comment #1:

Hi,

I have been keeping this code up to date in a
mercurial repository hosted here:
https://bitbucket.org/cdf1/octave/branch/dorigo

The patch attached is obtained by issuing the command

Carlo de Falco <cdf>
Project Member
Sun 04 Sep 2016 09:31:44 AM UTC, original submission:

Dear all,

this is a revised version of some work by Cristiano Dorigo at SoCiS16. I think it should be ready to be included in 4.2.

I will continue to revise the remaining work and, when ready, I will propose to add to the linear-algebra package.

The main features here are:

1) common syntax detection
2) three different scripts for the matrix case, the function_handle case and the mixed case
3) improved documentation, examples and demos
4) several corner cases fixed (see the blog by Cristiano Dorigo)
5) better detection of non-SPD matrices in pcg
6) detection of singular preconditioners
7) improved compatibility with Matlab

Marco Caliari <caliari>
Project MemberIn charge of this item.

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #39963:  SOCIS2016-3.diff added by caliari (186KiB - application/x-tex)
file #39638:  SOCIS2016-2.diff added by caliari (186KiB - application/x-tex)
file #39637:  SOCIS2016.diff added by caliari (190KiB - application/x-tex)
file #39100:  open_3a6C3Q2N.txt added by cdf (172KiB - text/plain)
file #39099:  open_3a6C3Q2N.txt added by cdf (172KiB - text/plain)
file #38426:  pcg_gmres.diff added by caliari (80KiB - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by cdf (Updated the item)
  • -email is unavailable- added by caliari (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 7 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2017-03-10 caliari Attached File- => Added SOCIS2016-3.diff, #39963
    2017-02-01 caliari Attached File- => Added SOCIS2016-2.diff, #39638
    2017-02-01 caliari Attached File- => Added SOCIS2016.diff, #39637
    2016-11-29 cdf Attached File- => Added open_3a6C3Q2N.txt, #39100
    2016-11-29 cdf Attached File- => Added open_3a6C3Q2N.txt, #39099
        Assigned toNone => caliari
    2016-09-04 caliari Attached File- => Added pcg_gmres.diff, #38426

    Back to the top


    Powered by Savane 3.3