patchGNU Octave - Patches: patch #9061, generate_html: fixing bug in...

 
 

patch #9061: generate_html: fixing bug in generate_package_html when no exist url field

Submitted by:  Fernando Pujaico Rivera <trucomanx>
Submitted on:  Thu 28 Jul 2016 05:44:06 PM UTC  
 
Category: NonePriority: 5 - Normal
Status: NonePrivacy: Public
Assigned to: NoneOpen/Closed: Open

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 28 Jul 2016 07:01:03 PM UTC, comment #1:

The code was found in the generate_package_html.m file in the line 518

Fernando Pujaico Rivera <trucomanx>
Thu 28 Jul 2016 05:44:06 PM UTC, original submission:

In the version 0.1.12 of generate_html package
we have the next code

if (isfield (list, "url")) && (! isempty (list.url))
index_write_homepage_links (fid, list.url);
endif

but, in the current source code version we have:

if (! isempty (list.url))
index_write_homepage_links (fid, list.url);
endif

It is wrong no verify first if exist the url field.

I adding a patch, but you can fix it manually.

Fernando Pujaico Rivera <trucomanx>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #38042:  bug-no-url.diff added by trucomanx (876B - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by trucomanx (Submitted the item)
  • -unavailable- added by trucomanx (generate_html: fixing bug in generate_package_html when no exist url field)
  • -unavailable- added by trucomanx (generate_html: fixing bug in generate_package_html when no exist url field)
  • -unavailable- added by trucomanx (generate_html: fixing bug in generate_package_html when no exist url field)
  • -unavailable- added by trucomanx (generate_html: fixing bug in generate_package_html when no exist url field)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 28 Jul 2016 05:44:06 PM UTCtrucomanxAttached File-=>Added bug-no-url.diff, #38042
      Carbon-Copy-=>Added -unavailable-
      Carbon-Copy-=>Added -unavailable-
      Carbon-Copy-=>Added -unavailable-
      Carbon-Copy-=>Added -unavailable-

    Back to the top


    Powered by Savane 3.1-cleanup1