patchGNU Octave - Patches: patch #9055, [octave forge] (signal) rssq: new...

 
 

patch #9055: [octave forge] (signal) rssq: new function

Submitter:  Çağrı Özkan <chaozk>
Submitted:  Wed 20 Jul 2016 09:30:28 PM UTC
   
 
Category:  Forge : new function Priority:  5 - Normal
Status:  Wont Do Privacy:  Public
Assigned to:  mtmiller Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Wed 04 Apr 2018 07:35:05 AM UTC, comment #2: 

I'm sorry but I had an implementation of rssq from earlier that I have added to the signal package now.

I did review your function file, and it is functionally identical. However, the function I have added has a more complete doc string, proper error handling, and more unit tests and input validation tests. These features are all as important as having the correct code.

Mike Miller <mtmiller>
Group Member
Sat 31 Dec 2016 12:10:38 PM UTC, comment #1: 

This functions gives the same results as MATLAB. I used the MATLAB examples to test.

The only difference is that this errors when it's passed a string but it doesn't in the MATLAB implementation. I really don't think this is a problem though.

Good work.

B/W,

Chris

Chris <elca>
Wed 20 Jul 2016 09:30:28 PM UTC, original submission:  

Hello;

I wrote a rssq.m function which I believe hasn't been implemented yet. Mercurial repo is at https://bitbucket.org/chaozk/octave-signal

I haven't been able to implement work into the project, so I apologize if I didn't contribute properly.


Çağrı Özkan <chaozk>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by mtmiller (Updated the item)
  • -email is unavailable- added by elca (Posted a comment)
  • -email is unavailable- added by chaozk (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-04-04 mtmiller Open/ClosedOpen Closed
    2018-04-04 mtmiller StatusNone Wont Do
    2018-03-30 mtmiller Assigned toNone mtmiller
        Summaryoctave-signal rssq.m function [octave forge] (signal) rssq: new function

    Back to the top

    Powered by Savane 3.13-4448.
    Corresponding source code