patchGNU Octave - Patches: patch #9048, Matlab compatible publish function

 
 

patch #9048: Matlab compatible publish function

Submitted by:  Kai Torben Ohlhus <siko1056>
Submitted on:  Tue 12 Jul 2016 04:02:24 PM UTC  
 
Category: Core : new functionPriority: 3 - Low
Status: DonePrivacy: Public
Assigned to: Kai Torben Ohlhus <siko1056>Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 18 Jul 2016 03:11:42 PM UTC, comment #5:

Done http://hg.code.sf.net/p/octave/miscellaneous/rev/2979fe3a4a55

Carnë Draug <carandraug>
Project Member
Sat 16 Jul 2016 11:53:41 PM UTC, comment #4:

Regarding comment #3, I vote for completely removing publish from the miscellaneous package. Sorry for forgetting about this aspect. The output of publish in miscellaneous is not overwhelming and as you mentioned, it is not maintained, not Matlab compatible, and switching from that one to the newer publish should be easy to manage.

Kai Torben Ohlhus <siko1056>
Project MemberIn charge of this item.
Fri 15 Jul 2016 01:50:12 PM UTC, comment #3:

Just to be clear on something that was not mentioned on this patch yet, this is a work on top of the publishd function from the miscellaneous package:

http://hg.code.sf.net/p/octave/miscellaneous/file/ae5cf73a03e1/inst/publish.m

It was also listed on the tasks #12153 "Incorporate Octave-Forge core functions into Octave"

https://savannah.gnu.org/task/?12153

What should be done about the miscellaneous package? How incompatible is this new version? Is it worth keep the older one under a different name?

Some possible approaches:

  • remove publish from miscellaneous
  • remove publish from miscellaneous and bump its dependency to Octave 4.2
  • have installation of miscellaneous only include the old version of publish() in Octave versions that miss the function
  • duplicate the new implementation of publish() to the miscellaneous package and install it only in Octave versions that miss the function
  • rename the old version of publish in the miscellaneous package, and deprecate it (maybe mixed with one of the options above)

I'm leaning towards the first solution since the package is not really maintained and I don't remember anyone mentioning using that function from that package.

Carnë Draug <carandraug>
Project Member
Fri 15 Jul 2016 10:38:52 AM UTC, comment #2:

Thank you Colin for your encouragement!

I have pushed the patch: http://hg.savannah.gnu.org/hgweb/octave/rev/b6f482e29afd

Kai Torben Ohlhus <siko1056>
Project MemberIn charge of this item.
Tue 12 Jul 2016 09:08:55 PM UTC, comment #1:

Awesome! This feature is very useful in teaching so I would think it should be high priority.

Will will try to test when I get a chance.

Colin Macdonald <cbm>
Tue 12 Jul 2016 04:02:24 PM UTC, original submission:

As another new feature for Octave 4.2 I would like to contribute a Matlab compatible publish <-> grabcode pair. See

https://www.mathworks.com/help/matlab/ref/publish.html

My recent development happened here:

https://github.com/siko1056/octave-publish

A tested patch for Octave default is attached. Last open topic: should the tests in

be silenced or treated diffently? I will push this patch within the next week.

Kai Torben Ohlhus <siko1056>
Project MemberIn charge of this item.

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #37824:  patch-publish.diff added by siko1056 (67KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by cbm (Posted a comment)
  • -unavailable- added by cbm
  • -unavailable- added by siko1056 (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 15 Jul 2016 10:38:52 AM UTCsiko1056StatusReady For Test=>Done
      Open/ClosedOpen=>Closed
    Tue 12 Jul 2016 09:08:55 PM UTCcbmCarbon-Copy-=>Added cbm
    Tue 12 Jul 2016 04:02:24 PM UTCsiko1056Attached File-=>Added patch-publish.diff, #37824

    Back to the top


    Powered by Savane 3.1-cleanup1