patchGNU Octave - Patches: patch #9019, [octave forge] (communications)...

 
 

patch #9019: [octave forge] (communications) alternative qammod, bin2gray, recpulse, rcosfir

Submitted by:  None
Submitted on:  Sun 05 Jun 2016 06:32:13 PM UTC  
 
Category:  Forge : other Priority:  5 - Normal
Status:  Need Info Privacy:  Public
Assigned to:  None Originator Email:  -email is unavailable-
Open/Closed:  Open

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 06 Jun 2016 06:35:45 PM UTC, comment #2:

Hello,

I'm sorry but I do not know how patch against the communications repository :(. The only way I've seen is explained here but I'm not sure about doing it well.

http://octave.sourceforge.net/developers.html

If you don't mind I'll just explain the changes here.

1) qammod (updated) - now it is able to modulate the x sequence with gray coding (for square constellations) and with user defined coding. Before it only used binary coding, i.e. not coding.

2) bin2gray - convert binary to gray code for square constellations.

3) rectpulse - repeats n times each IQ sample

4) rcosfir - implements cosine and root cosine filter

5) upfirdn - Discard it, the current implementation is far better.

Regards,

Anonymous
Mon 06 Jun 2016 01:02:40 AM UTC, comment #1:

Thanks for taking an interest in contributing. It would be very helpful if you could submit this as several patches against the communications repository. Ideally each function would be a separate patch tracker item, but that's less important.

Also, upfirdn is already implemented in the signal package, and belongs in the signal package, not communications. Can you explain what your m-file implementation improves on or why it should be used instead?

The qammod function is already implemented in communications, can you explain what your function improves on, and provide in the form of a diff against the current sources rather than a new file?

Mike Miller <mtmiller>
Project Administrator
Sun 05 Jun 2016 06:32:13 PM UTC, original submission:

Dear Octave team,

find enclosed in this post some missing functions that I've needed and implemented.

1) qammod (updated)
2) bin2gray
3) recpulse
4) rcosfir
5) upfirdn

Regards,

Òscar

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #37396:  communications-patch.zip added by None (6KiB - application/x-zip-compressed - Patch to the communication toolbox)
file #37397:  communications-patch.zip added by None (6KiB - application/x-zip-compressed - Patch to the communication toolbox)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by lachlan (Updated the item)
  • -email is unavailable- added by mtmiller (Posted a comment)
  • -email is unavailable- added by None (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-03-30 mtmiller Summarycommunications package: alternative qammod, bin2gray, recpulse, rcosfir => [octave forge] (communications) alternative qammod, bin2gray, recpulse, rcosfir
    2016-07-07 lachlan CategoryNone => Forge : other
    2016-06-06 mtmiller StatusNone => Need Info
        SummarySome missing function in communications package => communications package: alternative qammod, bin2gray, recpulse, rcosfir
    2016-06-05 None Attached File- => Added communications-patch.zip, #37396
        Attached File- => Added communications-patch.zip, #37397

    Back to the top


    Powered by Savane 3.3