Dear all,

I attach a new patch input_control sparse_2.diff. In this new one there are all the changes that were in the first one (so the first one now is useless), moreover now also bicg, bicgstab, cgs, pcr and qmr use the function _default__input_.m to control the values of tol, maxit and x0 and to set these into default values if necessary.

Best regards,
Cristiano Dorigo


(file #37020)

Dear all,
I submitted a proposal for the GSOC16 project mentioned in the summary.
In the attached patch there is an idea of how to work for the first part of the project.

I wrote the private function _default__input_.m that performs as follows:
[varargout] = _default__input.m_(def_val, varargin) and verifies the values of the varargin variables, if they are filled then varargout{i} = varargin{i}, otherwise if they miss or are empty thevarargout{i} = def_val{i}, where def_val is a cell array that contains the defaul desired values.

Then I substituted the internal input control of restart,rtol,maxit in the gmres code using the previous function and the same for tol,maxit,x0 in pcg.

I made the function _default__input_ more general as possible because the variables that need a control in gmres and pcg are different (in this specific case gmres has the restart values that pcg hasn't).

The next step could be at first to improve and/or fix this function if there are some useless things and/or missing features , then to extend this input check for the other algorithms mentioned in the GSOC project (pcr, bicg, bicgstab, cgs, and qmr). Then I think that can be useful another private function that check if are consistent the matrix A, the preconditioners M1, M2 and the right-hand-side vector b.

Please don't hesistate to give me some advices, observations or tell me if I'm working in an uncorrected road.