patchGNU Octave - Patches: patch #8956, F3 for "Find Next",...

 
 

patch #8956: F3 for "Find Next", shift+F3 for "Find Prev"

Submitted by:  Lachlan Andrew <lachlan>
Submitted on:  Fri 25 Mar 2016 06:20:07 AM UTC  
 
Category:  Core : new feature Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  Lachlan Andrew <lachlan> Open/Closed:  Closed

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

( Jump to the original submission)

Sat 23 Jul 2016 07:41:39 AM UTC, comment #8: 
Torsten Lilge <ttl>
Project Member
Fri 22 Jul 2016 09:10:21 PM UTC, comment #7: 

I tested again and it works fine.

As Lachlan correctly stated (comment #2), only selected text is automatically copied to the search pane.

As far as I am concerned this patch can be pushed.

Philip Nienhuis <philipnienhuis>
Project Member
Wed 06 Jul 2016 02:16:30 PM UTC, comment #6: 

Thanks for updating this patch, Torsten.

Would you be able to push it before the 4.2.0 feature freeze, or is there something else I should do?

Lachlan Andrew <lachlan>In charge of this item.
Mon 13 Jun 2016 08:24:16 PM UTC, comment #5: 

Attached a revised patch where the find dialog uses the same actions (and shortcuts) as the editor for find next/prev.

(file #37469)

Torsten Lilge <ttl>
Project Member
Sun 12 Jun 2016 02:12:59 PM UTC, comment #4: 

Lachlan, thanks for the patch.
We should avoid the key-event filter which makes the shortcuts in the find dialog hard coded and not configurable. The related editor actions might be propagated to the find dialog; I will have a look into this.

Torsten Lilge <ttl>
Project Member
Tue 07 Jun 2016 09:39:01 PM UTC, comment #3: 

Lachlan,

IIRC Torsten has added that Ctrl-F select word thing some months ago (or maybe it was a patch by him).

Indeed, I usually have ~ 10-15 or so patches in my builds; ATM most of the patches by you, I guess because you are so productive while accepting your patches seems to lag a bit behind.

It seems you struggle with the same little issues as I do with the difference that you are able, or have more perseverance, to fix them :-)  For which I, in turn, am grateful.

Philip Nienhuis <philipnienhuis>
Project Member
Tue 07 Jun 2016 03:03:01 AM UTC, comment #2: 

Thanks for testing this, Philip.

I haven't noticed Ctrl+F adding that word under the cursor in the search box, unless the word is selected.  Also, I like the idea of having separate key sequences for separate actions: a new search vs a repeated search.

You seem to run a system with lots of patches -- I'm impressed that you can keep track of them all.  I have a few more in the works, which aren't ready to be released yet.  If you like living on the edge, I'll post some here when I get a chance, and you can play with them.  (No pressure -- I'm really grateful for all the help you have already given me in testing and encouragement.)

Lachlan Andrew <lachlan>In charge of this item.
Tue 29 Mar 2016 09:30:13 AM UTC, comment #1: 

Works fine, my vote is to accept this patch.

Q:
When the cursor is on a word in the editor, and one enters Ctrl-F, the search window opens with the word in the search box (or there was another patch to that effect that I had applied at a time).
Can F3 also be made to do that? (i.e., do a Ctrl-F the first time it is invoked).
Maybe that can be done in the shortcuts as well? I tried but that didn't work. Anyway I see that just one shortcut per action can be specified; F3 would replace Ctrl-F which isn't very handy IMO

Philip Nienhuis <philipnienhuis>
Project Member
Fri 25 Mar 2016 06:20:07 AM UTC, original submission:  

In most applications, F3 does "Find Next", which I find really useful, but in Octave's editor it doesn't.

The attached patch causes F3 and shift+F3 do Find Next and Find Prev.

Torsten, you seem to be the main person in charge of the GUI.  Could you please assign this to a suitable reviewer?  Thanks!

Lachlan Andrew <lachlan>In charge of this item.

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #37469:  find_next-prev_shortcuts.diff added by ttl (12KiB - text/x-diff)
file #36757:  f3_find_next.cset added by lachlan (9KiB - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by ttl (Posted a comment)
  • -email is unavailable- added by philipnienhuis
  • -email is unavailable- added by lachlan (Submitted the item)
  • -email is unavailable- added by lachlan
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 7 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2016-07-23 ttl StatusReady For Test => Done
        Open/ClosedOpen => Closed
    2016-07-07 lachlan CategoryNone => Core : new feature
    2016-06-13 ttl Attached File- => Added find_next-prev_shortcuts.diff, #37469
    2016-03-29 philipnienhuis Carbon-Copy- => Added philipnienhuis
    2016-03-25 lachlan Attached File- => Added f3_find_next.cset, #36757
        Carbon-Copy- => Added ttl

    Back to the top


    Powered by Savane 3.5