patchGNU Octave - Patches: patch #8913, remove zlib from public API

 
 

patch #8913: remove zlib from public API

Submitted by:  Mike Miller <mtmiller>
Submitted on:  Fri 19 Feb 2016 05:07:44 AM UTC  
 
Category: Core : otherPriority: 5 - Normal
Status: In ProgressPrivacy: Public
Assigned to: NoneOpen/Closed: Open

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Fri 19 Feb 2016 02:22:56 PM UTC, comment #1:

I thought about a solution like this, and maybe it is sufficient for now.

Longer term, I am thinking about simplifying the octave_stdiostream classes by hiding the difference between FILE and gzFile in a separate class. Then we might be able to hide our use of zlib in a single file instead of having details of zlib spread over multiple files in Octave.

John W. Eaton <jwe>
Project Administrator
Fri 19 Feb 2016 05:07:44 AM UTC, original submission:

First attempt at removing zlib from the public Octave API.

I think this may fail to build when building without zlib, just posting for now to show my work. Building with zlib succeeds and all tests pass as before. Public header files no longer include zlib.h or need a HAVE_ZLIB macro.

This is related to bug #41027.

Mike Miller <mtmiller>
Project Administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #36393:  zlib.diff added by mtmiller (13KiB - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by lachlan (Updated the item)
  • -unavailable- added by jwe (Posted a comment)
  • -unavailable- added by mtmiller (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 07 Jul 2016 02:07:15 AM UTClachlanCategoryNone=>Core : other
    Fri 19 Feb 2016 05:07:44 AM UTCmtmillerAttached File-=>Added zlib.diff, #36393

    Back to the top


    Powered by Savane 3.1-cleanup1