The attached patch should apply cleanly on top of file #37935 in patch #8864 "smooth3".

(file #37936)

Markus, if you would like this considered for 4.2.0, could you please wrap lines at 72 columns (or perhaps up to 79) except the typedefun lines, and create a Mercurial changeset?

Thanks for appreciating my nitpicking :-)

Should we wait for smooth3.m to be provided?
It can take some time before your contributions are added to the repo, so maybe this isn't a bad idea. Same goes for isocaps, if you want to.

Marvellous job! Thanks very much

As to coding style, I've only managed to spot and change the "~" operator in lines 137, 144 and 151 to "! ".

Your family name didn't come through - I hope you don't mind I spelled it as Muetzel in the copyright line?
As your name is in the function, I suppose you do not mind to be mentioned in the list of contributors?

I tried the example on the Mathworks site; that works well as far as other missing functions go (smooth3, isocaps, camlight, lighting); the resulting picture resembles the shape on the TMW page quite well.
That's as far as I can test the validity and proper operation of the function.

I'll cc an other core devs about his opinion on where to put it (I'm merely a contributor with push credentials).

@Rik:
If you agree, I can make a cs & push it to default in the next week or week after.  Where should it be put? plot/util? image? geometry? statistics?


(file #36058)

Quite (=very) good for a first contribution! Thank you.

Nevertheless :-)  some points I noted in a ~2 minute scan:

Texinfo header:
---------------

• The first deftypefnx should without the trailing x: deftypefn

• The first sentence of the help is OK, but what is lacking is the rest of the help text, i.c., information on the required and the optional input parameters and what output arguments the function returns. Maybe even usage examples? Octave users shouldn't have to resort to the Matlab on-line help, should they :-)

E.g., only by perusing the code I noted somewhere that the function requires either three or six input arguments (according to Matlab it should be 2 or 5). That should be in the texinfo help text, to be displayed when doing:

help reducevolume

Code style (-nitpicking):
-------------------------

• We prefer ! negation operators rather than ~

In L.67 I read "if (numel (r) ~= 3)". It should rather be != or maybe "if ! (numel (r) == 3)"

• On L.71 "if any (r(:) < 1 | r(:) != fix (r(:)))": The entire if condition (any ...... ) should be enclosed in parentheses.

• We start comments with double ## rather than single # or %

• L.87 "x = 1:size(data, 2);" size() is a function so we prefer a space between size and the left paren: "x = 1:size (data, 2);"

General (important!):
---------------------

• I see no tests. Can you provide tests, also for input validation? For code & style examples see a.o., strread.m