I still include this patch in my windows builds, mostly out of routine I guess :-)

Mike Miller pointed something out about random BIST results (comment #6). I never encountered the problem - but then again I seldomly use the functions.

@Nick:
Great if you'd update histcounts & histogram. I second the preference for an .m file version for easier maintenance and I also agree that a compiled version would require "a wider audience".

Once you get it fixed we'd have to decide on where to push it to. Mike wanted core Octave, but it's as easy to put in in the OF statistics package. I've been adding quite a few contributions there lately so it's about time to make a new release in which histcounts & histogram could be included as well.

Opinions?

no since his requires compilation I didn't get a chance to try it out.  if i have some time later i might peek at the algorithms and see if i can lift any tweaks from there to fix Lars' code.  (otherwise if it's sufficiently standalone I could probably just mkoctfile his code and play from there, but I don't have a C++ IDE to step through, so prefer to live in m-space)

running through a few examples from the matlab help, i think at least Philip's version is not quite compatible yet. (i'm not set up to compile octave to test, so can't say whether the c version works) e.g.,:

Matlab doc:

X = [2 3 5 7 11 13 17 19 23 29];
[N,edges] = histcounts(X,6)
N = 1×6

     2     2     2     2     1     1

edges = 1×7

         0    4.9000    9.8000   14.7000   19.6000   24.5000   29.4000

Octave:

X = [2 3 5 7 11 13 17 19 23 29];
[N,edges] = histcounts(X,6)
N =

   3   1   2   2   1   1

edges =

 Columns 1 through 6:

    2.0000    6.5000   11.0000   15.5000   20.0000   24.5000

 Column 7:

   29.0000

Matlab docs:

X = primes(100);
[N,edges] = histcounts(X, 'Normalization', 'probability')
N = 1×4

    0.4000    0.2800    0.2800    0.0400

edges = 1×5

     0    30    60    90   120

Octave:

X = primes(100);
 [N,edges] = histcounts(X, 'Normalization', 'probability')
N =

   0.4400   0.2800   0.2800

edges =

    2.0000   33.6667   65.3333   97.0000

Hey all, I recently wrote my own implementation for the histcounts function. If all goes well I also have a histogram implementation in the works.

I'm giving you the raw files since I'm not sure where to put the C++ or how to integrate it into the build system. The principal files are histcounts.m and histcountsbin.cc.

The C++ will probably need some cleanup from my lack of experience. It will take a little while to compile because it accommodates for the integer types.

I've included some testing functions in the tarball. Use the paralleltest function to run them. You'll need pkg:parallel and MATLAB installed.

(file #45153)

Very well.

So, as Lars has never been CC'd I guess your comment #1 also never reached him.
I've put his email (from the patch) in the cc list.

No, this has nothing to do with importdata or what the random seed is. I have started Octave multiple times (different random initial state each time) and run 'test histcounts' alone multiple times, and it always fails randomly when the test is repeated. Like I said, the test is buggy. Either the random vector that it is operating on is outside of its expected range (doubtful), or the alogrithm inside of the histcounts function is missing some corner case that the random vector is exercising (more likely).

The histcounts function should be in Octave, in the scripts/statistics directory just as the patch makes it.

The summary line of the doc string for histcounts should probably mention the input variable X (e.g. "Compute histogram bin counts for the data array @var{x}").

The second paragraph starting with "Input arguments: X ..." and the last paragraph starting with "Output arguments: N ..." do not fit with Octave doc string style.

There are some code style issues (extra or missing space before or after parentheses, missing parentheses on "switch" argument, missing parentheses around complex logical conditions). There are a couple of trailing spaces in the doc string block that should be deleted.

The test suite is buggy, running it repeatedly causes failures in some of the tests that rely on random input data. I haven't looked into it to see whether this is a bug in the test formulation or a bug in the histcounts function itself.

Attached is an updated patch.
I've fixed it cf. comment #2 and added the missing module.mk entries to include them in dist archives + removed them from__unimplemented__.m
NEWS entries are not added yet.

I've been including this patch for a looong time now, I think they can be incorporated straight away; maybe except histcounts.m as that may live in the OF statistics package?


(file #43985)

Q:
In histcounts I see this stanza in L.201-205:

        case "BinWidth"
          binwidth = varargin{++iarg};
          if (! isreal (binmethod))
            error ("histcounts: BinWidth must be followed by a real number");
          endif

Shouldn't the if statement check if "binwidth" rather than "binmethod" is real?

(looks like a copy-paste from he switch clause above)