patchGNU Octave - Patches: patch #8668, [octave forge] (signal) firls: add...

 
 

patch #8668: [octave forge] (signal) firls: add demos, tests, etc

Submitted by:  Rob Sykes <robsykes>
Submitted on:  Mon 04 May 2015 01:40:06 PM UTC  
 
Category:  Forge : other Priority:  5 - Normal
Status:  Postponed Privacy:  Public
Assigned to:  Mike Miller <mtmiller> Open/Closed:  Open

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue 03 Apr 2018 07:02:40 AM UTC, comment #1:

There has been a lot more work done on an updated firls function with more Matlab compatibility options in bug #51310, along with some test cases. I would rather see the effort combined there.

I will be happy to incorporate more tests and demos into that submission. But I don't think the option you've added here to allow the amplitude vector to be half of the band edge vector is Matlab compatible, so I would rather not include support for that.

I will leave this open as a reminder to adapt the tests and demos into the firls update once it's been added to the package.

Mike Miller <mtmiller>
Project AdministratorIn charge of this item.
Mon 04 May 2015 01:40:06 PM UTC, original submission:
  • Add demos (comparable with those in firpm)
  • Add initial tests
  • Support giving 1 amplitude/band
  • Fix some documentation typos
Rob Sykes <robsykes>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #33896:  firls.patch.xz added by robsykes (2KiB - application/x-xz - add demos & initial tests; support giving 1 amplitude/band; fix a couple of typos)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by mtmiller (Updated the item)
  • -email is unavailable- added by robsykes (Submitted the item)
  • -email is unavailable- added by robsykes
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 8 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-04-03 mtmiller StatusNone => Postponed
    2018-03-30 mtmiller CategoryForge : new feature => Forge : other
    2018-03-30 mtmiller CategoryNone => Forge : new feature
        Summarysignal package: firls: add demos etc. => [octave forge] (signal) firls: add demos, tests, etc
    2015-12-22 mtmiller Assigned toNone => mtmiller
        Summary[signal] firls: add demos etc. => signal package: firls: add demos etc.
    2015-05-04 robsykes Carbon-Copy- => Added mtmiller
    2015-05-04 robsykes Attached File- => Added firls.patch.xz, #33896

    Back to the top


    Powered by Savane 3.3