patchGNU Octave - Patches: patch #8668, [octave forge] (signal) firls: add...


patch #8668: [octave forge] (signal) firls: add demos, tests, etc

Submitted by:  Rob Sykes <robsykes>
Submitted on:  Mon 04 May 2015 01:40:06 PM UTC  
Category: Forge : otherPriority: 5 - Normal
Status: PostponedPrivacy: Public
Assigned to: Mike Miller <mtmiller>Open/Closed: Open

Add a New Comment(Rich Markup)

You are not logged in

Please log in, so followups can be emailed to you.


Tue 03 Apr 2018 07:02:40 AM UTC, comment #1:

There has been a lot more work done on an updated firls function with more Matlab compatibility options in bug #51310, along with some test cases. I would rather see the effort combined there.

I will be happy to incorporate more tests and demos into that submission. But I don't think the option you've added here to allow the amplitude vector to be half of the band edge vector is Matlab compatible, so I would rather not include support for that.

I will leave this open as a reminder to adapt the tests and demos into the firls update once it's been added to the package.

Mike Miller <mtmiller>
Project AdministratorIn charge of this item.
Mon 04 May 2015 01:40:06 PM UTC, original submission:
  • Add demos (comparable with those in firpm)
  • Add initial tests
  • Support giving 1 amplitude/band
  • Fix some documentation typos
Rob Sykes <robsykes>


(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):

Attached Files
file #33896:  firls.patch.xz added by robsykes (2KiB - application/x-xz - add demos & initial tests; support giving 1 amplitude/band; fix a couple of typos)


Depends on the following items: None found

Items that depend on this one: None found


Carbon-Copy List
  • -unavailable- added by mtmiller (Updated the item)
  • -unavailable- added by robsykes (Submitted the item)
  • -unavailable- added by robsykes

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.


    Please enter the title of George Orwell's famous dystopian book (it's a date):



    Follow 8 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 03 Apr 2018 07:02:40 AM UTCmtmillerStatusNone=>Postponed
    Fri 30 Mar 2018 02:19:42 AM UTCmtmillerCategoryForge : new feature=>Forge : other
    Fri 30 Mar 2018 02:06:18 AM UTCmtmillerCategoryNone=>Forge : new feature
      Summarysignal package: firls: add demos etc.=>[octave forge] (signal) firls: add demos, tests, etc
    Tue 22 Dec 2015 06:01:51 PM UTCmtmillerAssigned toNone=>mtmiller
      Summary[signal] firls: add demos etc.=>signal package: firls: add demos etc.
    Mon 04 May 2015 01:40:07 PM UTCrobsykesCarbon-Copy-=>Added mtmiller
    Mon 04 May 2015 01:40:06 PM UTCrobsykesAttached File-=>Added firls.patch.xz, #33896

    Back to the top

    Powered by Savane 3.1-cleanup1