patchGNU Octave - Patches: patch #8630, [octave forge] (signal) stepz: new...

 
 

patch #8630: [octave forge] (signal) stepz: new function

Submitted by:  Patrick Noffke <pnoffke>
Submitted on:  Thu 26 Mar 2015 03:36:35 PM UTC  
 
Category: Forge : new functionPriority: 5 - Normal
Status: Need InfoPrivacy: Public
Assigned to: Mike Miller <mtmiller>Open/Closed: Open

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 06 Apr 2015 06:56:17 PM UTC, comment #4:

Yes please, test for use as a function with output arguments only.

If you want to add a %!demo section showing what an example plot would look like, that is an option and would be great also.

You can also add input validation tests to ensure that bad arguments to the function are correctly caught as errors, search for %!error in other m-files to see examples of this.

Mike Miller <mtmiller>
Project AdministratorIn charge of this item.
Mon 06 Apr 2015 06:49:08 PM UTC, comment #3:

Yes, the copyright was a copy & paste "error." Should I retain Paul as copyright owner (and add my name) since my patch was a derivative of his impz function?

Regarding the unit test, I can add those for the output data (nargout > 0). Do you also recommend unit tests for the plot part (nargout == 0)? If so, I'm not sure how to do that.

Thanks.

Patrick Noffke <pnoffke>
Fri 03 Apr 2015 02:53:52 AM UTC, comment #2:

Yes, please do update copyright header. Could also use some Octave style fixes (parens around if conditions, spaces after function names, etc). Can you add some unit tests to the function as well?

Mike Miller <mtmiller>
Project AdministratorIn charge of this item.
Thu 02 Apr 2015 05:38:55 PM UTC, comment #1:

The copyright in the attached patch is

is this a copy & paste error?

Andreas Weber <andy1978>
Project Member
Thu 26 Mar 2015 03:36:35 PM UTC, original submission:
Patrick Noffke <pnoffke>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #33461:  add-stepz.diff added by pnoffke (4KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by mtmiller (Posted a comment)
  • -unavailable- added by andy1978 (Posted a comment)
  • -unavailable- added by pnoffke (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 30 Mar 2018 02:19:30 AM UTCmtmillerCategoryNone=>Forge : new function
    Fri 30 Mar 2018 02:09:41 AM UTCmtmillerSummarysignal package: add function stepz=>[octave forge] (signal) stepz: new function
    Tue 22 Dec 2015 06:02:26 PM UTCmtmillerSummaryAdd stepz to signal package.=>signal package: add function stepz
    Fri 03 Apr 2015 02:53:52 AM UTCmtmillerStatusNone=>Need Info
      Assigned toNone=>mtmiller
    Thu 26 Mar 2015 03:36:35 PM UTCpnoffkeAttached File-=>Added add-stepz.diff, #33461

    Back to the top


    Powered by Savane 3.1-cleanup1