patchGNU Octave - Patches: patch #8630, [octave forge] (signal) stepz: new...


patch #8630: [octave forge] (signal) stepz: new function

Submitter:  Patrick Noffke <pnoffke>
Submitted:  Thu 26 Mar 2015 03:36:35 PM UTC
Category:  Forge : new function Priority:  5 - Normal
Status:  Need Info Privacy:  Public
Assigned to:  mtmiller Open/Closed:  Open
* Mandatory Fields

Add a New Comment (Rich Markup)

Comment Type & Canned Response:


Mon 06 Apr 2015 06:56:17 PM UTC, comment #4: 

Yes please, test for use as a function with output arguments only.

If you want to add a %!demo section showing what an example plot would look like, that is an option and would be great also.

You can also add input validation tests to ensure that bad arguments to the function are correctly caught as errors, search for %!error in other m-files to see examples of this.

Mike Miller <mtmiller>
Project Administrator
Mon 06 Apr 2015 06:49:08 PM UTC, comment #3: 

Yes, the copyright was a copy & paste "error."  Should I retain Paul as copyright owner (and add my name) since my patch was a derivative of his impz function?

Regarding the unit test, I can add those for the output data (nargout > 0).  Do you also recommend unit tests for the plot part (nargout == 0)?  If so, I'm not sure how to do that.


Patrick Noffke <pnoffke>
Fri 03 Apr 2015 02:53:52 AM UTC, comment #2: 

Yes, please do update copyright header. Could also use some Octave style fixes (parens around if conditions, spaces after function names, etc). Can you add some unit tests to the function as well?

Mike Miller <mtmiller>
Project Administrator
Thu 02 Apr 2015 05:38:55 PM UTC, comment #1: 

The copyright in the attached patch is

## Copyright (C) 1999 Paul Kienzle <>

is this a copy & paste error?

Andreas Weber <andy1978>
Project Member
Thu 26 Mar 2015 03:36:35 PM UTC, original submission:  
Patrick Noffke <pnoffke>


(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:

Attached Files
file #33461:  add-stepz.diff added by pnoffke (4KiB - text/x-patch)


Depends on the following items: None found

Items that depend on this one: None found


Carbon-Copy List
  • -email is unavailable- added by andy1978 (Posted a comment)
  • -email is unavailable- added by pnoffke (Submitted the item)

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.





    Follow 7 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2019-03-07 mtmiller Carbon-CopyRemoved 80942 -
    2018-03-30 mtmiller CategoryNone Forge : new function
    2018-03-30 mtmiller Summarysignal package: add function stepz [octave forge] (signal) stepz: new function
    2015-12-22 mtmiller SummaryAdd stepz to signal package. signal package: add function stepz
    2015-04-03 mtmiller StatusNone Need Info
        Assigned toNone mtmiller
    2015-03-26 pnoffke Attached File- Added add-stepz.diff, #33461

    Back to the top

    Powered by Savane 3.9