patchGNU Octave - Patches: patch #8575, [octave forge] (signal) lpc: new...

 
 

patch #8575: [octave forge] (signal) lpc: new function

Submitted by:  None
Submitted on:  Tue 18 Nov 2014 08:36:38 PM UTC  
 
Category: Forge : new functionPriority: 5 - Normal
Status: Need InfoPrivacy: Public
Assigned to: Mike Miller <mtmiller>Originator Email: -unavailable-
Open/Closed: Open

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Mon 16 Apr 2018 08:17:30 PM UTC, comment #6:

I've just added a missing assertion in test.

(file #43955)

Leonardo <leolca>
Fri 13 Apr 2018 09:14:59 PM UTC, comment #5:

I've made some corrections and improvements.

(file #43921)

Leonardo <leolca>
Thu 12 Apr 2018 05:10:06 PM UTC, comment #4:

Thank you for the changes. There is still more work to be done to make this Matlab compatible and to conform to our coding style.

Mike Miller <mtmiller>
Project AdministratorIn charge of this item.
Thu 05 Apr 2018 07:28:55 PM UTC, comment #3:

Thanks for the feedback!
I've made some corrections and improvements. Two demos were added. One of them requires a sample audio file provided by ltfat package. I hope it is okay.

(file #43813)

Leonardo <leolca>
Wed 04 Apr 2018 06:03:19 AM UTC, comment #2:

Thank you for your work on this lpc function file. I'm sorry it has taken so long for me to get around to looking at this submission.

The lpc function is definitely needed in the signal package, and your function seems basically functionally correct to me. There are some Matlab compatibility issues remaining, and some additional error checking that could be added to ensure x and p are correct. For example, Matlab lpc can be called with one argument, and p defaults to length(x)-1. The function should also verify that x is real. The value p can be equal to length(x). And the prediction error second return value should be a scalar, not a vector result.

This is definitely a good candidate function for including a demo that will be shown in the online manual. For example a demo that creates an autoregressive process and shows the original signal against the estimate, similar to what is shown on Matlab's help page.

And beyond that there are some small Octave coding style changes to make (use spaces before parentheses, but not when indexing; use '!' instead of '~'; use the name of the variable uppercased instead of 'arg 1' in error messages).

Again, sorry for the delay, but let me know if you are interested and motivated to work on this a bit more and submit another revision.

Mike Miller <mtmiller>
Project AdministratorIn charge of this item.
Tue 18 Nov 2014 11:54:25 PM UTC, comment #1:

Thanks for your contribution. As we discussed over email, assigning myself to review and merge this into the signal package.

Mike Miller <mtmiller>
Project AdministratorIn charge of this item.
Tue 18 Nov 2014 08:36:38 PM UTC, original submission:

A small contribution to octave-signal follows in the forked repository
https://bitbucket.org/leolca/octave-signal
or also attached here.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #43955:  lpc.m added by leolca (4KiB - text/x-objcsrc)
file #43954:  lpc.m added by leolca (4KiB - text/x-objcsrc - just added a missing assert in test)
file #43921:  lpc.m added by leolca (4KiB - text/x-objcsrc)
file #43813:  lpc.m added by leolca (4KiB - text/x-objcsrc)
file #32468:  lpc.m added by None (2KiB - text/x-objcsrc)

 

Depends on the following items: None found

Digest:
   patch dependencies.

 

Carbon-Copy List
  • -unavailable- added by leolca (Updated the item)
  • -unavailable- added by mtmiller (Posted a comment)
  • -unavailable- added by None (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 12 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 16 Apr 2018 08:17:30 PM UTCleolcaAttached File-=>Added lpc.m, #43955
    Mon 16 Apr 2018 08:16:20 PM UTCleolcaAttached File-=>Added lpc.m, #43954
    Fri 13 Apr 2018 09:14:59 PM UTCleolcaAttached File-=>Added lpc.m, #43921
    Thu 05 Apr 2018 07:28:55 PM UTCleolcaAttached File-=>Added lpc.m, #43813
    Wed 04 Apr 2018 06:03:19 AM UTCmtmillerStatusNone=>Need Info
    Fri 30 Mar 2018 02:10:10 AM UTCmtmillerCategoryNone=>Forge : new function
      Summarysignal package: lpc - linear predictor=>[octave forge] (signal) lpc: new function
    Thu 14 Apr 2016 09:41:27 PM UTCmtmillerDependencies-=>patch #8980 is dependent
    Tue 18 Nov 2014 11:54:25 PM UTCmtmillerAssigned toNone=>mtmiller
      Summarylinear predictor=>signal package: lpc - linear predictor
    Tue 18 Nov 2014 11:52:24 PM UTCmtmillerDependencies-=>patch #8574 is dependent
    Tue 18 Nov 2014 08:36:38 PM UTCNoneAttached File-=>Added lpc.m, #32468

    Back to the top


    Powered by Savane 3.1-cleanup1