Add a New Comment (Rich Markup)
Comment Type & Canned Response: None None Please use the bug tracker for bugs
[INT_MIN+1, INT_MAX], the other "regular" [INT_MIN, INT_MAX].
----------
As discussed in https://mailman.cae.wisc.edu/pipermail/octave-maintainers/2013-November/037580.html
Notes:
- Cases where xisint() was used were not touched as they are already correct (but may be a little too strict). This is for ease of review, plus my understanding is that the interpreter has now to be kept in sync with the JIT compiler. Thus, no well-defined behavior should have been changed. - I only tested an Octave-default build without the JIT compiler, as that one gave build errors for an LLVM from SVN (is Octave following a particular LLVM build, such as one available with a distro's package management?) - The predicates use ceil() as that one is declared inline (see below)
Additional attachments:
- xpow_tests.m: an annotated M script containing Sanitizer output before the cleanup and some other annotations - xisint.cc: a very simple C++ test file for timing the predicates when run in a loop. Results: inlining seems to give a noticeable speedup (hence ceil()), my versions compile to somewhat shorter code.
xpow_test.m also shows something curious: running a = -single([1,2;3,4]); b=single([1 1; 1 2^32]); a.^b calls the (const FloatNDArray& a, const FloatNDArray& b) overload, not the FloatMatrix one. Not a big deal I guess, since the former is more general, but maybe noteworthy.
(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)
Attach Files: Comment:
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Only logged-in users can vote.
Please enter the title of George Orwell's famous dystopian book (it's a date):
Follow 4 latest changes.
Copyright © 2022 Free Software Foundation, Inc. Verbatim copying and distribution of this entire article is permitted in any medium, provided this notice is preserved. The Levitating, Meditating, Flute-playing Gnu logo is a GNU GPL'ed image provided by the Nevrax Design Team. Source Code
Powered by Savane 3.9