patchGNU Octave - Patches: patch #8141, [octave forge] (signal) levinson:...

 
 

patch #8141: [octave forge] (signal) levinson: deal with matrix input (matlab compatibility)

Submitted by:  None
Submitted on:  Wed 31 Jul 2013 02:17:58 PM UTC
 
Category:  Forge : other Priority:  3 - Low
Status:  Postponed Privacy:  Public
Assigned to:  mtmiller Originator Email:  -email is unavailable-
Open/Closed:  Open
* Mandatory Fields

Add a New Comment (Rich Markup)
   

Comment Type & Canned Response:
       

 

Thu 01 Aug 2013 04:17:05 AM UTC, comment #2: 

Thanks Mike for having a look at it. Sorry for the problems applying it.

I just recently dug this up. I tried submitting a few years back but I think it got lost in the shuffle.

I will try and get the octave source checked out next week and get an updated patch with some better testing on it. Stay tuned.

Joe Romano <jromano>
Thu 01 Aug 2013 04:02:52 AM UTC, comment #1: 

Hi, thanks for your contribution to the signal package. I can incorporate this as is, but it needs some clean up. Would you be willing to look at the following and post an updated patch?

  • Can you submit this in the form of a mercurial changeset against the current signal package repository, including a proper commit message? The attached patch does not apply cleanly for me.
  • Prefer columns(x) to size(x,2).
  • Make sure the function still works on row vectors, I think your patch inadvertently breaks that.
Mike Miller <mtmiller>
Project Administrator
Wed 31 Jul 2013 02:17:58 PM UTC, original submission:  

The Octave version of levinson.m does not have the ability to handle matrices with multiple columns of input data for the first input argument. As noted in the matlab documentation a matrix input should be handled by picking off each column of the input and processing it separately. The change was simple enough to make the existing levinson.m Octave function handle this case.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #28722:  levinson.patch added by None (2KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jromano (Posted a comment)
  • -email is unavailable- added by None (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

     

     

     

    Follow 9 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2019-03-07 mtmiller Carbon-CopyRemoved 80942 => -
    2018-03-30 mtmiller CategoryNone => Forge : other
        Summarysignal package: levinson.m deal with matrix input (matlab compatibility) => [octave forge] (signal) levinson: deal with matrix input (matlab compatibility)
    2015-02-22 mtmiller Priority5 - Normal => 3 - Low
        StatusNeed Info => Postponed
    2013-08-01 mtmiller StatusNone => Need Info
        Assigned toNone => mtmiller
        Summarysingal package: levinson.m deal with matrix input (matlab compatibility) => signal package: levinson.m deal with matrix input (matlab compatibility)
    2013-07-31 None Attached File- => Added levinson.patch, #28722

    Back to the top


    Powered by Savane 3.9