patchGNU Octave - Patches: patch #7537, Handle matlab way to store cell...

 
 

patch #7537: Handle matlab way to store cell arrays in hdf5 files.

Submitted by:  Mathias Fröhlich <frohlich>
Submitted on:  Thu 28 Apr 2011 04:36:32 PM UTC
 
Category:  Core : new feature Priority:  5 - Normal
Status:  Wont Do Privacy:  Public
Assigned to:  None Open/Closed:  Closed
* Mandatory Fields

Add a New Comment (Rich Markup)
   

Comment Type & Canned Response:
       

 

Wed 10 Nov 2021 07:25:59 PM UTC, comment #3: 

Closing 10yr old submission.  Can revisit if someone wants to reevaluate applicability to the current version of Octave .

Nicholas Jankowski <nrjank>
Project Member
Fri 30 Jul 2021 08:00:34 PM UTC, comment #2: 

(err, patch not bug)

Nicholas Jankowski <nrjank>
Project Member
Fri 30 Jul 2021 07:59:38 PM UTC, comment #1: 

patch obviously hasn't been implemented in 6.3.0 yet. with line changes it applies to libinterp\corefcn\ls-hd5.cc, but there have been a number of changes to the modified sections of libinterp\octave-value\ov-cell.cc in the interim.

would recommend someone familiar with current hdf5 capability review the intent of the patch and see if it's even still needed and worth salvaging, otherwise close bug as a 'won't fix'

Nicholas Jankowski <nrjank>
Project Member
Thu 28 Apr 2011 04:36:32 PM UTC, original submission:  

Hi,

I have extended the hdf5 loader routines to handle datasets of object references in hdf5 files.
Matlab uses this for hdf5/mat files to store cell arrays.
Also it appears sensible to me to import object reference datasets as cell arrays.

The change extends the cell array hdf5 load function by the code that is able to interpret object references. Also the cell array's load_hdf5 method is used in case of an object reference dataset.
The hdf group iteration function is adapted to use H5O_info which replaces the today deprecated and currently used H5G_info function. Using that change, this iteration function can easily be reused for traversing the referenced objects from the new code path.
Using this patch, I am able to load simple matlab V7.3 hdf5 files containing simple cell arrays including the stored cell arrays which did not show up before.

The patch is developed against the current release version 3.4.0. But it also applies fine to todays hg mainline.

Please review, apply and/or suggest improvements.

Thanks

Mathias

Mathias Fröhlich <frohlich>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #23320:  octave-cell.diff added by frohlich (9KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by nrjank (Posted a comment)
  • -email is unavailable- added by lachlan (Updated the item)
  • -email is unavailable- added by frohlich (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

     

     

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2021-11-10 nrjank StatusNone => Wont Do
        Open/ClosedOpen => Closed
    2016-07-07 lachlan CategoryNone => Core : new feature
    2011-04-28 frohlich Attached File- => Added octave-cell.diff, #23320

    Back to the top


    Powered by Savane 3.9