patchGNU Octave - Patches: patch #10361, Fixed varargin bug in VM

 
 

patch #10361: Fixed varargin bug in VM

Submitter:  Petter <petter>
Submitted:  Sat 24 Jun 2023 11:56:40 PM UTC
   
 
Category:  Core : other Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  None Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Tue 29 Aug 2023 11:47:05 PM UTC, comment #2: 

No complaints. Closing as done.

Arun Giridhar <arungiridhar>
Group Member
Sat 15 Jul 2023 10:38:33 AM UTC, comment #1: 

Thank you for your patch.

Regarding your comment "Why does not "if exist b" work here in either VM or tree walker?":
`exist b` is in command syntax what `exist ('b')` is in function syntax. When calling functions in command syntax, their output cannot be used in the program. For the `if` statement, you need the output of the expression for the condition. So, command syntax doesn't work in that context.
(I hope that explanation isn't completely off...)

The new parts of the BIST pass when I build with your patch here, so I pushed it with minor changes to the default branch:
https://hg.savannah.gnu.org/hgweb/octave/rev/4b48ab05ba02

Marking as ready for test.

(Like I already wrote in the other report: It might be better to post future bug fixes on the bug tracker. It gets a bit more attention...)

Markus Mützel <mmuetzel>
Group administrator
Sat 24 Jun 2023 11:56:40 PM UTC, original submission:  

"

  • libinterp/parse-tree/pt-bytecode-vm.cc: Expand cs-lists into arguments properly


  • test/compile/bytecode.tst: Updated tests
  • test/compile/bytecode_varargin.m

"

Solves problem with the VM found by running "pkg test stk".

Petter <petter>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #54867:  octave_32269.patch added by petter (3KiB - text/plain)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by arungiridhar (Posted a comment)
  • -email is unavailable- added by mmuetzel (Posted a comment)
  • -email is unavailable- added by petter (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2023-08-29 arungiridhar StatusReady For Test Done
        Open/ClosedOpen Closed
    2023-07-15 mmuetzel StatusNone Ready For Test
    2023-06-24 petter Attached File- Added octave_32269.patch, #54867

    Back to the top

    Powered by Savane 3.13-4b48.
    Corresponding source code