patchGNU Octave - Patches: patch #10235, interpreter: Non-virtual calls in...


patch #10235: interpreter: Non-virtual calls in op:s and ov inline constructor

Submitter:  John W. Eaton <jwe>
Submitted:  Wed 22 Jun 2022 01:46:15 PM UTC
Category:  Core : other Priority:  5 - Normal
Status:  None Privacy:  Public
Assigned to:  None Open/Closed:  Open
* Mandatory Fields

Add a New Comment Rich Markup

Wed 01 Mar 2023 02:17:49 PM UTC, comment #4: 

Fixed it! Attaching an updated patch new_30617c.patch. You'll need a and c both. I'm deleting b to avoid confusion since that won't apply any more.

(file #54431)

Arun Giridhar <arungiridhar>
Group Member
Wed 01 Mar 2023 01:35:32 PM UTC, comment #3: 

After the change from DYNORSTAT_CAST to OCTAVE_CAST_BASE_VALUE in changeset a9c8b1f8fb32, this patch no longer applies cleanly. Applying everything in the sequence up to new_30617a still works (applies and builds), but new_30617b causes conflicts and fixing them manually causes compile errors.

Arun Giridhar <arungiridhar>
Group Member
Tue 28 Feb 2023 01:48:08 PM UTC, comment #2: 

Turns out my previous patch hadn't included a new header file, so I'm adding that. For consistency, I'm renaming the previous patch I submitted and calling them a and b instead. Apply both in sequence.

(file #54422, file #54423)

Arun Giridhar <arungiridhar>
Group Member
Tue 28 Feb 2023 11:46:12 AM UTC, comment #1: 

Updated patch attached. This needs patches new_30599 onwards to be applied in sequence first.

(file #54421)

Arun Giridhar <arungiridhar>
Group Member
Wed 22 Jun 2022 01:46:15 PM UTC, original submission:  

From Petter Tomner <petter>, extracted from the zip file attached to the following comment in the discourse thread "WIP stack VM f\
or Octave":

Speed up operators by doing non-virtual calls in the operator
definitions and use builder functions for octave_values that
are inlinable.

Make some getters final to avoid derived classes overriding
and messing up the direct calls in the operator definitions.

John W. Eaton <jwe>
Group administrator


(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:

Attached Files
file #54431:  new_30617c.patch added by arungiridhar (22KiB - text/x-patch)
file #54422:  new_30617a.patch added by arungiridhar (3KiB - text/x-patch)
file #53353:  octave_30617.patch added by jwe (26KiB - text/x-patch)


Depends on the following items: None found

Items that depend on this one: None found


Carbon-Copy List
  • -email is unavailable- added by arungiridhar (Updated the item)
  • -email is unavailable- added by jwe (Submitted the item)
  • -email is unavailable- added by jwe

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.


    Follow 8 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2023-03-01 arungiridhar Attached File#54423 Removed
    2023-03-01 arungiridhar Attached File- Added new_30617c.patch, #54431
    2023-02-28 arungiridhar Attached File#54421 Removed
    2023-02-28 arungiridhar Attached File- Added new_30617a.patch, #54422
        Attached File- Added new_30617b.patch, #54423
    2023-02-28 arungiridhar Attached File- Added new_30617.patch, #54421
    2022-06-22 jwe Attached File- Added octave_30617.patch, #53353
        Carbon-Copy- Added petter

    Back to the top

    Powered by Savane 3.12.
    Corresponding source code