patchGNU Octave - Patches: patch #10189, mxe-octave: upgrade libbiosig to...

 
 

patch #10189: mxe-octave: upgrade libbiosig to v2.4.1

Submitter:  Alois Schlögl <schloegl>
Submitted:  Sat 19 Mar 2022 04:23:05 PM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  None Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Thu 05 May 2022 07:01:43 PM UTC, comment #9: 

The tests for the package are passing on the GitHub runners testing the Octave for Windows nightly builds:
https://github.com/gnu-octave/octave-buildbot/actions/runs/2265222026

Closing as done.

Markus Mützel <mmuetzel>
Group administrator
Sat 23 Apr 2022 01:58:46 PM UTC, comment #8: 

I don't know how to test if the package actually works other than running `pkg test biosig`. But those tests seem to pass now (still with the additional patch in MXE Octave).

Also the load path looks ok to me after loading and after unloading the package.

I pushed the update to the library and the package here:
https://hg.octave.org/mxe-octave/rev/1d3ec84b2a49

It should be part of the next minor release of Octave (or the nightlies).

Marking as ready for test.

Markus Mützel <mmuetzel>
Group administrator
Sat 23 Apr 2022 01:09:01 PM UTC, comment #7: 


Thanks, I've updated the package in place.

The new checksum is
59d5bfd5be64207753ed6d505dbb7e462c0e1670645491fea9c50d7822451f0e



Alois Schlögl <schloegl>
Sat 23 Apr 2022 11:18:24 AM UTC, comment #6: 

The package doesn't load correctly.

In comparison to the biosig package version 2.4.0, the PKG_ADD and PKG_DEL files are missing from the tarball at:
https://pub.ist.ac.at/~schloegl/biosig/prereleases/biosig4octave-2.4.1.src.tar.gz

Markus Mützel <mmuetzel>
Group administrator
Fri 22 Apr 2022 07:36:36 PM UTC, comment #5: 

Oops. I meant "relocating" not "relocalizing"... (Is the latter even a word?)

Markus Mützel <mmuetzel>
Group administrator
Fri 22 Apr 2022 07:32:14 PM UTC, comment #4: 

Thanks for the update.

I noticed the pkgconfig file contains the following (for me in MXE Octave):

prefix=/home/osboxes/Documents/Repositories/Octave/mxe-octave-release-1/usr/x86_64-w64-mingw32
exec_prefix=/home/osboxes/Documents/Repositories/Octave/mxe-octave-release-1/usr/x86_64-w64-mingw32
libdir=/home/osboxes/Documents/Repositories/Octave/mxe-octave-release-1/usr/x86_64-w64-mingw32/lib
includedir=/home/osboxes/Documents/Repositories/Octave/mxe-octave-release-1/usr/x86_64-w64-mingw32/include


To facilitate relocalizing the package, it would be nice if that could be this instead (maybe for the next release?):

prefix=/home/osboxes/Documents/Repositories/Octave/mxe-octave-release-1/usr/x86_64-w64-mingw32
exec_prefix=${prefix}
libdir=${exec_prefix}/lib
includedir=${prefix}/include


I'll try and check your changes shortly.

Wrt the Octave packages index, it would be nice if you could create a PR to that repository on GitHub. If you log in, you could probably edit that file directly in their web interface:
https://github.com/gnu-octave/packages/blob/main/packages/biosig.yaml

Markus Mützel <mmuetzel>
Group administrator
Fri 22 Apr 2022 08:21:18 AM UTC, comment #3: 


libbiosig 2.4.1 is released.
That attached patch upgrade libbiosig in mxe-octave.

Most important, it fixes a problem when reading the sameple rate of IgorBinaryWaveform (IBW) data.

I hope it is ok to use the same thread.


There is also patch for the octave-packages repostory included.



(file #53130, file #53131)

Alois Schlögl <schloegl>
Sat 19 Mar 2022 06:41:27 PM UTC, comment #2: 

Kai started a nice new listing of Octave packages some time ago:
https://gnu-octave.github.io/packages/
I noticed that the biosig package isn't listed yet on that page.

The sources for that list are managed on GitHub:
https://github.com/gnu-octave/packages

If you'd like to add the biosig package to that listing, you could send a pull request to that repository.

Markus Mützel <mmuetzel>
Group administrator
Sat 19 Mar 2022 06:35:29 PM UTC, comment #1: 

I pushed your patch here:
https://hg.octave.org/mxe-octave/rev/fbe6eb75e6d6

And followed up with a second patch that updates the biosig Octave package to the same version here:
https://hg.octave.org/mxe-octave/rev/ed702ff01c8e

In the latter patch, I included a small patch for sumskipnan.m so that `pkg test biosig` passes also when the "nan" package isn't loaded beforehand.

Both changeset were pushed to the release branch of MXE Octave. So, they should be part of Octave 7.1 when it is released (or a RC3 - whatever comes first).

Marking as ready for test.

Markus Mützel <mmuetzel>
Group administrator
Sat 19 Mar 2022 04:23:05 PM UTC, original submission:  


biosig 2.4.0 is available, thus libbiosig in mxe-octave should be updated. The patch is attached.



Alois Schlögl <schloegl>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by mmuetzel (Posted a comment)
  • -email is unavailable- added by schloegl (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 9 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2022-05-05 mmuetzel StatusReady For Test Done
        Open/ClosedOpen Closed
    2022-04-23 mmuetzel StatusIn Progress Ready For Test
    2022-04-22 mmuetzel StatusReady For Test In Progress
        Summarymxe-octave: upgrade libbiosig to v2.4.0 mxe-octave: upgrade libbiosig to v2.4.1
    2022-04-22 schloegl Attached File- Added upgrade-libbiosig-v241.patch, #53130
        Attached File- Added patch-upgrade-biosig4octave-2.4.1.diff, #53131
    2022-03-19 mmuetzel StatusNone Ready For Test
    2022-03-19 schloegl Attached File- Added upgrade-libbiosig-v240.patch, #53007

    Back to the top

    Powered by Savane 3.13-4b48.
    Corresponding source code