patchGNU Octave - Patches: patch #10089, Update documentation of...

 
 

patch #10089: Update documentation of disable_diagonal_matrix, disable_permutation_matrix, and disable_range functions

Submitter:  José Luis García Pallero <jgpallero>
Submitted:  Fri 30 Jul 2021 02:58:11 PM UTC
 
Category:  Core : other Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  None Open/Closed:  Closed
* Mandatory Fields

Add a New Comment (Rich Markup)
   

Comment Type & Canned Response:
       

 

Wed 03 Nov 2021 05:33:26 AM UTC, comment #2: 

Patch now released in 6.4.0.

Closing item.

Kai Torben Ohlhus <siko1056>
Project Member
Fri 30 Jul 2021 03:35:31 PM UTC, comment #1: 

Thanks for your patch.

I made some more changes to the wording.
Imho, it doesn't matter how the interpreter keeps track of that setting. So I removed all references to "internal variable".
I also tried to reverse the sense of the introductory sentence to better match what those functions actually do. (They disable whether Octave uses the corresponding types.)

It could probably still be worded a bit more elegantly. But I think this is better than what we had before.

I pushed the updated patch with you as the author to stable here:
https://hg.savannah.gnu.org/hgweb/octave/rev/a3ac00db296b

Marking as ready for test.

Markus Mützel <mmuetzel>
Project Member
Fri 30 Jul 2021 02:58:11 PM UTC, original submission:  
José Luis García Pallero <jgpallero>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by siko1056 (Posted a comment)
  • -email is unavailable- added by mmuetzel (Posted a comment)
  • -email is unavailable- added by jgpallero (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

     

     

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2021-11-03 siko1056 StatusReady For Test Done
        Open/ClosedOpen Closed
    2021-07-30 mmuetzel StatusNone Ready For Test
    2021-07-30 jgpallero Attached File- Added disable_functions_help_update.patch, #51707

    Back to the top


    Powered by Savane 3.9