patchGNU Octave - Patches: patch #10059, [octave forge] (signal) Add BIST...

 
 

patch #10059: [octave forge] (signal) Add BIST for cheb1ap

Submitter:  None
Submitted:  Fri 23 Apr 2021 08:45:59 PM UTC
   
 
Category:  Forge : new feature Priority:  5 - Normal
Status:  None Privacy:  Public
Assigned to:  None Originator Email:  -email is unavailable-
Open/Closed:  Open
* Mandatory Fields

Add a New Comment Rich Markup
   

Tue 12 Sep 2023 04:38:55 PM UTC, comment #4: 

Apart from that the patch looks good

John Donoghue <lostbard>
Group Member
Tue 12 Sep 2023 04:17:40 PM UTC, comment #3: 

With your change of

- elseif (! isscalar (Rp) || ! isnumeric (Rp) || Rp < 0)
+ elseif (! isscalar (Rp) || ! isnumeric (Rp) || Rp <= 0)

 octave does:

[z,p,k]=cheb1ap(2,0)
error: cheb1ap: RP must be a non-negative scalar


But matlab returns p, k as Inf.

John Donoghue <lostbard>
Group Member
Mon 11 Sep 2023 04:39:53 PM UTC, comment #2: 

CC'ing John Donoghue who managed the latest releases of the signal package.

Markus Mützel <mmuetzel>
Group administrator
Sat 09 Sep 2023 10:16:44 PM UTC, comment #1: 

Could this be looked into for the next version release signal?

Anonymous
Fri 23 Apr 2021 08:45:59 PM UTC, original submission:  

Updated function
Rp cannot be 0
Gain should be real

Added
Docstring
Tests

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #51312:  cheb1ap.patch added by None (2KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by lostbard (Posted a comment)
  • -email is unavailable- added by mmuetzel (Posted a comment)
  • -email is unavailable- added by mmuetzel
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 2 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2023-09-11 mmuetzel Carbon-Copy- Added lostbard
    2021-04-23 None Attached File- Added cheb1ap.patch, #51312

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code