patchGNU Octave - Patches: patch #10034, [octave forge] (statistics) Add...

 
 

patch #10034: [octave forge] (statistics) Add function optimalleaforder

Submitter:  None
Submitted:  Sat 27 Feb 2021 05:11:10 PM UTC
   
 
Category:  Forge : new function Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  philipnienhuis Originator Email:  -email is unavailable-
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Mon 01 Mar 2021 06:56:28 PM UTC, comment #4: 

OK, done.
pushed here:
http://hg.code.sf.net/p/octave/statistics/rev/88307452af1a

Closing report, thanks very much Stefano.

Philip Nienhuis <philipnienhuis>
Group Member
Mon 01 Mar 2021 11:15:05 AM UTC, comment #3: 

It seems ok. There are two things I noticed, that should be edited:

  • line 70: it seems that on MATLAB the default value is "linear", so for compatibility issues that line should be


transformation = "linear";

  • line 93: the elseif misses the parentheses.


I'll shortly post a patch to improve dendrogram, but there are some issues I should iron out first.

Anonymous
Sun 28 Feb 2021 05:40:47 PM UTC, comment #2: 

Attached is optimalleaforder.m with

  • style fixes
  • little more structured texinfo

+ noting that all property/value pairs must be char strings,

  • extra check for char values in varargin(3:end) + lower() before blindly feeding the values to the strcmp() in the ensuing switch statement
  • added a test for this.



Please let me know if you agree with these mods.


(file #50943)

Philip Nienhuis <philipnienhuis>
Group Member
Sat 27 Feb 2021 09:53:30 PM UTC, comment #1: 

Thanks.

I tried the 1st Matlab on-line example, works fine until the second subplot where it turns out that Octave's dendrogram.m only accepts just one input argument.

In comment #4 of patch #9985 I commented on some style things (that I already fixed here, was not so much) and on texinfo contents that I'm a bit more hesitant about. All info is there but I find it a bit too condensed. Just let me ponder a little on it.

Philip Nienhuis <philipnienhuis>
Group Member
Sat 27 Feb 2021 05:11:10 PM UTC, original submission:  

This patch adds the "optimalleaforder" function.

Currently it implements only the "adjacent" criterion, while in MATLAB there is also a "group" criterion.

Type "demo optimalleaforder" for an example.

Patch generated by "hg export -r tip".

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #50937:  optimalleaforder.diff added by None (10KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by philipnienhuis
  • -email is unavailable- added by None (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 7 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2021-03-01 philipnienhuis StatusIn Progress Done
        Open/ClosedOpen Closed
    2021-02-28 philipnienhuis Attached File- Added optimalleaforder.m, #50943
    2021-02-27 philipnienhuis StatusNone In Progress
        Assigned toNone philipnienhuis
        Carbon-Copy- Added philipnienhuis
    2021-02-27 None Attached File- Added optimalleaforder.diff, #50937

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code