bugPSPP - Bugs: bug #59818, doc/pspp.info: caption expected...

 
 

bug #59818: doc/pspp.info: caption expected braces

Submitter:  Jeremy Lavergne <snc>
Submitted:  Mon 04 Jan 2021 04:12:27 PM UTC
   
 
Category:  Documentation Severity:  5 - Average
Status:  Fixed Assigned to:  None
Open/Closed:  Closed Release:  None
Effort:  0.00
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Sun 25 Jun 2023 09:20:51 AM UTC, comment #12: 

Looking at the code in ./acinclude.m4 this seems to have been fixed.

John Darrington <jmd>
Group administrator
Mon 11 Jan 2021 10:17:21 PM UTC, comment #11: 


> Thanks to your pointers, I've now got it building docs with the correct makeinfo.


Hurray!

I'm going to leave this bug open for now as a reminder to make configure reject old "makeinfo".  (I think this will actually be good for users, since they will get a clearer message earlier in the build that there's a problem.)

Ben Pfaff <blp>
Group administrator
Mon 11 Jan 2021 10:15:25 PM UTC, comment #10: 

Sounds reasonable to me!

Thanks to your pointers, I've now got it building docs with the correct makeinfo.

The real root cause seems to be oversight on my end: I didn't tell MacPorts to allow access to its makeinfo and sandboxing resulted in the expected makeinfo being passed over.


comment #9:

> I think I'm going to check in a patch to reject any makeinfo that doesn't support @clicksequence.  I don't know a reason to support antique software like that.

Jeremy Lavergne <snc>
Mon 11 Jan 2021 09:27:23 PM UTC, comment #9: 


> This is building off the "nightly PSPP" builds at ovsorbit: is it possible something from that build has caused selection on the incorrect makeinfo?


I doubt it.

(ovsorbit? That's a different project.)

You can tell "configure" to use the correct "makeinfo" by pointing to it on the command line. "./configure MAKEINFO=/path/to/makeinfo", for example.

I think I'm going to check in a patch to reject any makeinfo that doesn't support @clicksequence.  I don't know a reason to support antique software like that.

Ben Pfaff <blp>
Group administrator
Mon 11 Jan 2021 09:18:46 PM UTC, comment #8: 

There is a system makeinfo (4.8) so there will always be more than one makeinfo on a Mac.

However the makeinfo (6.7) first in PATH is the one provided by MacPorts.

This is building off the "nightly PSPP" builds at ovsorbit: is it possible something from that build has caused selection on the incorrect makeinfo?


comment #7:

> I think that you have two versions of makeinfo installed.  One of them is pre-4.12.  That means it's really old, since Texinfo 4.12 was released in April 2008. Can you please figure out what's going on with that?

Jeremy Lavergne <snc>
Mon 11 Jan 2021 08:48:34 PM UTC, comment #7: 

It's pretty clear from config.log that makeinfo really doesn't understand @clicksequence:


configure:16085: checking whether makeinfo supports @clicksequence
configure:16094: running ${SHELL} /opt/local/var/macports/build/_Users_aeetes_macports-ports_math_pspp-devel/pspp-devel/work/pspp-1.4.2-g4f8462/build-aux/missing makeinfo conftest.texi >&5
conftest.texi:2: Unknown command `clicksequence'.
conftest.texi:2: Misplaced {.
conftest.texi:2: Unknown command `click'.
conftest.texi:2: Misplaced {.
conftest.texi:2: Misplaced }.
conftest.texi:2: Misplaced }.
makeinfo: Removing output file `/opt/local/var/macports/build/_Users_aeetes_macports-ports_math_pspp-devel/pspp-devel/work/pspp-1.4.2-g4f8462/conftest.info' due to errors; use --force to preserve.


The texinfo NEWS file says that Texinfo 4.12 added @clicksequence.

I think that you have two versions of makeinfo installed.  One of them is pre-4.12.  That means it's really old, since Texinfo 4.12 was released in April 2008. Can you please figure out what's going on with that?

Ben Pfaff <blp>
Group administrator
Mon 11 Jan 2021 08:43:59 PM UTC, comment #6: 

Attached a config.log from today. Snippet:


conftest.texi:2: Unknown command `clicksequence'.

Jeremy Lavergne <snc>
Mon 11 Jan 2021 08:27:09 PM UTC, comment #5: 

I see:

> checking whether makeinfo supports @clicksequence... yes
> checking whether makeinfo generates broken DocBook XML... no


This is odd.  makeinfo 6.7 should have the same behavior everywhere.

Would you please attach your config.log?


Ben Pfaff <blp>
Group administrator
Mon 11 Jan 2021 08:17:34 PM UTC, comment #4: 

On your end, does PSPP's configure report this about makeinfo?

checking whether makeinfo supports @clicksequence... no                                                                                
checking whether makeinfo generates broken DocBook XML... no                                                                           

Jeremy Lavergne <snc>
Mon 11 Jan 2021 06:56:35 PM UTC, comment #3: 


>texi2any (GNU texinfo) 6.7


Does not seem to be a version difference: I just rebuilt PSPP with Texinfo 6.7 and it worked just as well.

Ben Pfaff <blp>
Group administrator
Mon 11 Jan 2021 06:48:04 PM UTC, comment #2: 

Alrighty, here's the `makeinfo --version` response:

texi2any (GNU texinfo) 6.7

Copyright (C) 2017 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Jeremy Lavergne <snc>
Mon 11 Jan 2021 12:53:06 AM UTC, comment #1: 

I guess that this must correspond to some difference in the Texinfo version.  What does "makeinfo --version" say?  I'm using version 6.7 here.

Ben Pfaff <blp>
Group administrator
Mon 04 Jan 2021 04:12:27 PM UTC, original submission:  

I've been having issues building documentation via `make -w all html` since the change to how they're build the week after g4f8462/2020-10-05. I'm uncertain if this is the base issue, but currently I get many logged complaints about the @caption expecting braces.

Many entries similar to this one:
```
/opt/local/var/macports/build/_Users_aeetes_macports-ports_math_pspp-devel/pspp-devel/work/pspp-1.5.2-g21f20b/doc//transformation.texi:2
38: @caption expected braces.   
```

The other messages are akin to:
```
/opt/local/var/macports/build/_Users_aeetes_macports-ports_math_pspp-devel/pspp-devel/work/pspp-1.5.2-g21f20b/doc//transformation.texi:4
35: warning: `.' or `,' must follow @xref, not `f'.
/opt/local/var/macports/build/_Users_aeetes_macports-ports_math_pspp-devel/pspp-devel/work/pspp-1.5.2-g21f20b/doc//transformation.texi:9
01: Misplaced {.                                                                                                                        /opt/local/var/macports/build/_Users_aeetes_macports-ports_math_pspp-devel/pspp-devel/work/pspp-1.5.2-g21f20b/doc//transformation.texi:9
01: Misplaced }.
/opt/local/var/macports/build/_Users_aeetes_macports-ports_math_pspp-devel/pspp-devel/work/pspp-1.5.2-g21f20b/doc//data-selection.texi:1
77: @caption missing close brace.
```

Attached is macports logging while it was using `make` for pspp and the resulting `transformation.texi` file.

Jeremy Lavergne <snc>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #50701:  config.log.xz added by snc (47KiB - application/x-xz)
file #50644:  pspp.log.txz added by snc (43KiB - application/x-xz-compressed-tar - log from make)
file #50645:  transformation.texi.txz added by snc (11KiB - application/x-xz-compressed-tar - log from make)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jmd (Posted a comment)
  • -email is unavailable- added by blp (Posted a comment)
  • -email is unavailable- added by snc (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2023-06-25 jmd StatusNone Fixed
        Open/ClosedOpen Closed
    2021-01-11 snc Attached File- Added config.log.xz, #50701
    2021-01-04 snc Attached File- Added pspp.log.txz, #50644
        Attached File- Added transformation.texi.txz, #50645

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code