bugGNU Octave - Bugs: bug #40563, Remove unnecessary loop

 
 

bug #40563: Remove unnecessary loop

Submitter:  PrasannaKumar Muralidharan <prasannatsm>
Submitted:  Wed 13 Nov 2013 05:01:49 AM UTC
   
 
Category:  GUI Severity:  3 - Normal
Priority:  5 - Normal Item Group:  None
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * dev Operating System:  * Any
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Wed 13 Nov 2013 07:32:11 AM UTC, comment #2: 

Thanks for applying the patch.

PrasannaKumar Muralidharan <prasannatsm>
Wed 13 Nov 2013 06:11:32 AM UTC, comment #1: 

I changed the commit message to add a newline between the first line (summary of change) and the per-file detailed change log.  I also added a few more words to the detailed explanation.  You can see the complete result below.
 

Remove unnecessary loop in file_editor::handle_tab_remove_request.

file-editor.cc (handle_tab_remove_request): Use break to stop processing loop once tab is found.


It was applied here (http://hg.savannah.gnu.org/hgweb/octave/rev/46da2c323ad6).  I'll try and take a look at some of the Clang sanitize results myself as well.  Thanks for the patch.

Rik <rik5>
Group administrator
Wed 13 Nov 2013 05:01:49 AM UTC, original submission:  

Don't search after finding the correct entry.

PrasannaKumar Muralidharan <prasannatsm>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #29602:  remove_unnecessary_loop.diff added by prasannatsm (769B - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rik5 (Posted a comment)
  • -email is unavailable- added by prasannatsm (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2013-11-13 rik5 StatusNone Fixed
        Open/ClosedOpen Closed
    2013-11-13 prasannatsm Attached File- Added remove_unnecessary_loop.diff, #29602

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code