bugGNU Octave - Bugs: bug #35708, patch for cygwin build

 
 

bug #35708: patch for cygwin build

Submitter:  marco atzeri <matzeri>
Submitted:  Sat 03 Mar 2012 02:57:10 PM UTC
   
 
Category:  GUI Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Build Failure
Status:  Fixed Assigned to:  jacobdawid
Originator Name:  Open/Closed:  * Closed
Release:  * dev Operating System:  * Microsoft Windows
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Tue 07 Aug 2012 07:17:39 AM UTC, comment #2: 

we can close the bug as solved

marco atzeri <matzeri>
Sun 27 May 2012 09:45:39 PM UTC, comment #1: 

I have applied the changes with qterminal along with the changeset http://hg.savannah.gnu.org/hgweb/octave/rev/c952f1e35e50 .

See here:
http://code.google.com/p/qterminal/source/detail?r=5c51db4e3b1fcce6a05c59af5be78f43ebc24db4

Please test if you build now without problems.

Jacob Dawid <jacobdawid>
Sat 03 Mar 2012 02:57:10 PM UTC, original submission:  

attached patch to allow build on cygwin and additionally
solve the build failure on a separate tree.
It is versus changeset:   13693:d738c29a2528

qterminal/libqterminal/libqterminal.pro
qterminal/qterminal/qterminal.pro

both require
  DEFINES += HAVE_PTY_H HAVE_OPENPTY
for correctly defining the PTY

and the removal of
  DESTDIR        = .
to allow the build on a separate tree.
With DESTDIR defined, the Makefile will have a
  rm -r ./libqterminal.a
that destroy the just built library. With no
definition the build works fine.

qterminal/libqterminal/unix/kpty.cpp
needs some missing
  #ifndef HAVE_OPENPTY

see
http://kde4libs.sourcearchive.com/documentation/4.4.1/kpty_8cpp-source.html


marco atzeri <matzeri>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #25255:  gui_2.patch added by matzeri (3KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jordigh (Updated the item)
  • -email is unavailable- added by matzeri (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2012-08-07 jordigh StatusReady For Test Fixed
        Open/ClosedOpen Closed
    2012-05-27 jacobdawid StatusNone Ready For Test
    2012-03-05 jacobdawid Assigned toNone jacobdawid
    2012-03-03 matzeri Attached File- Added gui_2.patch, #25255

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code