bugGNU Octave - Bugs: bug #51763, [octave forge] (interval) fails to...

 
 

bug #51763: [octave forge] (interval) fails to build against Octave 4.3 dev

Submitter:  Mike Miller <mtmiller>
Submitted:  Wed 16 Aug 2017 02:39:22 AM UTC
   
 
Category:  Octave Package Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Build Failure
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * dev Operating System:  * GNU/Linux
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Wed 16 Aug 2017 09:19:04 PM UTC, comment #6: 

Works for me, thanks

Mike Miller <mtmiller>
Group Member
Wed 16 Aug 2017 09:07:45 PM UTC, comment #5: 
Oliver Heimlich <oheim>
Wed 16 Aug 2017 05:30:23 PM UTC, comment #4: 

Thanks, looks good. We can mark this fixed once your branch is merged into the main interval repository.

By the way, it is helpful to mark commit messages with "(bug #nnn)" in case someone needs to find the bug report associated with a change in the future.

Mike Miller <mtmiller>
Group Member
Wed 16 Aug 2017 05:19:29 PM UTC, comment #3: 

Oops, I only pushed the first commit. Now it should be there!

Joel Dahne <urathai>
Wed 16 Aug 2017 05:12:31 PM UTC, comment #2: 

I don't see a fix committed yet for the std::max template error, do you intend to fix that one too?

Mike Miller <mtmiller>
Group Member
Wed 16 Aug 2017 04:45:52 PM UTC, comment #1: 

The problem with source being called on a cell existed in 4.2 as well but the error in mpfr_function_d.cc was new to 4.3.

I have pushed changes to my GSoC repository, https://sourceforge.net/u/urathai/octave/ci/default/tree/, and Oliver will merge it to the standard repository eventually.

If you double check that this works it can then be considered fixed!

Joel Dahne <urathai>
Wed 16 Aug 2017 02:39:22 AM UTC, original submission:  

The interval package build fails against Octave's 4.3 dev branch with the following error:


mpfr_function_d.cc:111:34: error: no matching function for call to ‘max(octave_idx_type&, int)’
   for (int i = std::max (start, 1); i < dimensions; i ++)


It also fails because source() is called on a cell, this is a simple fix that should be backwards compatible. The attached diff allows the package to build against Octave 4.3 dev for me. Feel free to apply as-is or adjust as needed.

Mike Miller <mtmiller>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #41537:  interval-octave-4.3.diff added by mtmiller (1KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jwe (Updated the item)
  • -email is unavailable- added by oheim (Posted a comment)
  • -email is unavailable- added by urathai (Posted a comment)
  • -email is unavailable- added by mtmiller (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-07-02 jwe Summary[octave-forge] (interval) fails to build against Octave 4.3 dev [octave forge] (interval) fails to build against Octave 4.3 dev
    2017-08-16 mtmiller StatusReady For Test Fixed
        Open/ClosedOpen Closed
    2017-08-16 mtmiller StatusPatch Submitted Ready For Test
    2017-08-16 mtmiller Attached File- Added interval-octave-4.3.diff, #41537

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code