bugGNU Octave - Bugs: bug #51763, [octave-forge] (interval) fails to...

 
 

bug #51763: [octave-forge] (interval) fails to build against Octave 4.3 dev

Submitted by:  Mike Miller <mtmiller>
Submitted on:  Wed 16 Aug 2017 02:39:22 AM UTC  
 
Category: Octave Forge PackageSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Build Failure
Status: FixedAssigned to: None
Originator Name: Open/Closed: Closed
Release: devOperating System: GNU/Linux

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Wed 16 Aug 2017 09:19:04 PM UTC, comment #6:

Works for me, thanks

Mike Miller <mtmiller>
Project Administrator
Wed 16 Aug 2017 09:07:45 PM UTC, comment #5:

Merged and tested in Octave 3.8 and 4.0.

https://sourceforge.net/p/octave/interval/ci/cf97d56a8e2a3be36980f6ef4e004bef6db531d2/
https://sourceforge.net/p/octave/interval/ci/5ed7880c917fe36d5fef1eba8e8fb03027938cd4/

This bug may be closed.

Oliver Heimlich <oheim>
Wed 16 Aug 2017 05:30:23 PM UTC, comment #4:

Thanks, looks good. We can mark this fixed once your branch is merged into the main interval repository.

By the way, it is helpful to mark commit messages with "(bug #nnn)" in case someone needs to find the bug report associated with a change in the future.

Mike Miller <mtmiller>
Project Administrator
Wed 16 Aug 2017 05:19:29 PM UTC, comment #3:

Oops, I only pushed the first commit. Now it should be there!

Joel Dahne <urathai>
Wed 16 Aug 2017 05:12:31 PM UTC, comment #2:

I don't see a fix committed yet for the std::max template error, do you intend to fix that one too?

Mike Miller <mtmiller>
Project Administrator
Wed 16 Aug 2017 04:45:52 PM UTC, comment #1:

The problem with source being called on a cell existed in 4.2 as well but the error in mpfr_function_d.cc was new to 4.3.

I have pushed changes to my GSoC repository, https://sourceforge.net/u/urathai/octave/ci/default/tree/, and Oliver will merge it to the standard repository eventually.

If you double check that this works it can then be considered fixed!

Joel Dahne <urathai>
Wed 16 Aug 2017 02:39:22 AM UTC, original submission:

The interval package build fails against Octave's 4.3 dev branch with the following error:

It also fails because source() is called on a cell, this is a simple fix that should be backwards compatible. The attached diff allows the package to build against Octave 4.3 dev for me. Feel free to apply as-is or adjust as needed.

Mike Miller <mtmiller>
Project Administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #41537:  interval-octave-4.3.diff added by mtmiller (1KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by oheim (Posted a comment)
  • -unavailable- added by urathai (Posted a comment)
  • -unavailable- added by mtmiller (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 16 Aug 2017 09:19:04 PM UTCmtmillerStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Wed 16 Aug 2017 05:30:23 PM UTCmtmillerStatusPatch Submitted=>Ready For Test
    Wed 16 Aug 2017 02:39:22 AM UTCmtmillerAttached File-=>Added interval-octave-4.3.diff, #41537

    Back to the top


    Powered by Savane 3.1-cleanup1