bugGNU Octave - Bugs: bug #66988, (signal) Makefile is missing...

 
 

bug #66988: (signal) Makefile is missing PKG_CFLAGS

Submitter:  Dmitri A. Sergatskov <dasergatskov>
Submitted:  Fri 04 Apr 2025 01:49:33 AM UTC
   
 
Category:  Octave Package Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Build Failure
Status:  Ready For Test Assigned to:  lostbard
Originator Name:  Open/Closed:  * Open
Release:  * dev Operating System:  * Any
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Post a Comment

Add a New Comment Rich Markup
   

Discussion

Mon 14 Apr 2025 11:20:34 PM UTC, comment #1: 

added change to repo

John Donoghue <lostbard>
Group Member
Fri 04 Apr 2025 01:49:33 AM UTC, original submission:  

"PKG_CFLAGS" appears to be missing from src/Makefile
(*.c rules).

That prevents mmfir.c to be compiled with required flags (memory sanitizer flags in my case.


diff -r 8e02a735a50c src/Makefile
--- a/src/Makefile      Tue Apr 01 07:58:23 2025 -0400
+++ b/src/Makefile      Thu Apr 03 21:07:26 2025 -0400
@@ -42,7 +42,7 @@
        $(MKOCTFILE) $(PKG_CXXFLAGS) -c $< -o $@

 %.o: %.c
-       $(MKOCTFILE) -c $< -o $@
+       $(MKOCTFILE) $(PKG_CFLAGS) -c $< -o $@

 %.oct: %.cc octave-compat.h
        $(MKOCTFILE) $(PKG_CXXFLAGS) $< -o $@


Dmitri.
--



Dmitri A. Sergatskov <dasergatskov>

 

Attached Files

This item currently has no attached files.

(Note: upload size limit is set to 4.0MiB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

 

Dependencies

This item does not depend on any other items.

No items depend on this one.

 

Mail Notification Carbon-Copy List

Carbon-Copy List
  • -email is unavailable- added by lostbard (Posted a comment)
  • -email is unavailable- added by dasergatskov (Submitted the item)
  •  

    Votes

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

    History

    Follow 2 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2025-04-14 lostbard StatusNone Ready For Test
        Assigned toNone lostbard

    Back to the top

    Powered by Savane 3.16-598c.
    Corresponding source code