bugGNU Octave - Bugs: bug #66388, [octave forge] (statistics)...

 
 

bug #66388: [octave forge] (statistics) anovan: suggested help text example not working

Submitter:  Muhali <muhali>
Submitted:  Wed 30 Oct 2024 02:42:13 PM UTC
   
 
Category:  Octave Package Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Documentation
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * other Operating System:  * Any
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Mon 13 Jan 2025 05:46:14 PM UTC, comment #15: 

closing as fixed per maintainer's request.

Nicholas Jankowski <nrjank>
Group Member
Mon 13 Jan 2025 05:44:36 PM UTC, comment #14: 

Unless, there is something else related to the anovan function, this bug can be closed. Thanks

Andreas Bertsatos <pr0m1th3as>
Mon 13 Jan 2025 05:19:46 AM UTC, comment #13: 

comment #12:

> Sorry for the late reply. I applied the patch and pushed to main repo of statistics. Work permitted, I hope to make a new release by end of January to include this fix. Thanks to Swayam for the fix and everyone else for the help

Thank you
Looking forward to more contributions...

Sonu0305 <swayamshah>
Mon 13 Jan 2025 05:11:07 AM UTC, comment #12: 

Sorry for the late reply. I applied the patch and pushed to main repo of statistics. Work permitted, I hope to make a new release by end of January to include this fix. Thanks to Swayam for the fix and everyone else for the help

Andreas Bertsatos <pr0m1th3as>
Sat 11 Jan 2025 10:21:26 PM UTC, comment #11: 

comment #10:

> Actually I'd expect the statistics package maintainer to pick up but I haven't seen responses from him on this site for some weeks.
> I suppose he'll do when he returns.


Okay,No Problem
Thank You
Swayam (Sonu0305)

Sonu0305 <swayamshah>
Thu 09 Jan 2025 11:10:16 PM UTC, comment #10: 

Actually I'd expect the statistics package maintainer to pick up but I haven't seen responses from him on this site for some weeks.
I suppose he'll do when he returns.

Philip Nienhuis <philipnienhuis>
Group Member
Thu 09 Jan 2025 04:09:41 PM UTC, comment #9: 

comment #8:

> Yes I saw that, thank you.
> I'll have a look later on, maybe someone beats me to it.
> (status => "patch submitted")


Noted, Thank You.

Sonu0305 <swayamshah>
Wed 08 Jan 2025 10:33:33 PM UTC, comment #8: 

Yes I saw that, thank you.
I'll have a look later on, maybe someone beats me to it.
(status => "patch submitted")

Philip Nienhuis <philipnienhuis>
Group Member
Wed 08 Jan 2025 07:01:09 PM UTC, comment #7: 

comment #6:

> Thanks.
> I'm not fond of copying Mathworks stuff, even just "translated". Aren't there any other examples?  R project maybe?


I have submitted a patch regarding modifying the help text with a simple working example.
Thank You
Swayam (Sonu0305)

Sonu0305 <swayamshah>
Tue 10 Dec 2024 03:57:15 PM UTC, comment #6: 

Thanks.
I'm not fond of copying Mathworks stuff, even just "translated". Aren't there any other examples?  R project maybe?

Philip Nienhuis <philipnienhuis>
Group Member
Tue 10 Dec 2024 10:43:45 AM UTC, comment #5: 

comment #3:

> Would you have a suggestion for an example that can replace that help text stanza?


the following is a simple working example, slightly modified from the matlab documentation on anovan:

y = [52.7 57.5 45.9 44.5 53.0 57.0 45.9 44.0]';
g1 = {'1';'2';'1';'2';'1';'2';'1';'2'};
g2 = {'hi';'hi';'lo';'lo';'hi';'hi';'lo';'lo'};
g3 = {'may';'may';'may';'may';'june';'june';'june';'june'};
p = anovan(y,{g1,g2,g3})

It gives the basic idea and can easily be modified using different entries.

Muhali <muhali>
Mon 09 Dec 2024 11:43:21 AM UTC, comment #4: 

That it worked with 1.4.3 is suspicious, sure. But I think the help text should be fixed first.

Philip Nienhuis <philipnienhuis>
Group Member
Mon 09 Dec 2024 11:39:42 AM UTC, comment #3: 

Sure, the help text could be better, absolutely :-)
I do agree with the inconsistency you mentioned => confirmed.

I myself wouldn't have plugged those inputs directly into anovan, I'd see them more as a guide on what kind of inputs are expected. Hmmm, I guess I became quite a bit wary after 45+ years of reading IT-related manuals, that's probably why a took a different stand initially. But you're really right.

The anovan demos look pretty complex; a few simple examples in the help text that actually work could overcome a steep learning curve.

Would you have a suggestion for an example that can replace that help text stanza?

(title & tags adapted)

Philip Nienhuis <philipnienhuis>
Group Member
Mon 09 Dec 2024 10:31:41 AM UTC, comment #2: 

The help text has

------
P = anovan (Y, GROUP)
...
For example, if ‘Y = [1.1;1.2]; GROUP = [1,2,1; 1,5,2];’ then observation 1.1 was measured under conditions 1,2,1 and observation 1.2 was measured under conditions 1,5,2.
------

and it means to me that one can plug in Y and GROUP as mentioned without getting an error. My original example was slightly modified. Note also that it works with package version 1.4.3.

Muhali <muhali>
Fri 06 Dec 2024 07:14:13 PM UTC, comment #1: 

To me it looks like the OP didn't understand the help text. I don't see any call 'anovan ([1.1;1.2], [1,2; 1,2])' mentioned there.
IMO the part of the help text where the input args Y and GROUP are treated just indicates what the Y and GROUP input arguments do.
Possibly the help text can be a bit more clear.

cc'ing package maintainer anyway

Philip Nienhuis <philipnienhuis>
Group Member
Wed 30 Oct 2024 02:42:13 PM UTC, original submission:  

the simple example (from the help text)

anovan ([1.1;1.2], [1,2; 1,2])

throws the error

error: cat: dimension mismatch
error: called from
    cell2mat at line 86 column 11
    anovan at line 617 column 36


Muhali <muhali>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #56746:  0001-updated-help-text-example.patch added by swayamshah (2KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by nrjank (Posted a comment)
  • -email is unavailable- added by pr0m1th3as (Posted a comment)
  • -email is unavailable- added by philipnienhuis
  • -email is unavailable- added by swayamshah (Updated the item)
  • -email is unavailable- added by philipnienhuis
  • -email is unavailable- added by muhali (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 14 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2025-01-13 nrjank StatusPatch Submitted Fixed
        Open/ClosedOpen Closed
    2025-01-08 philipnienhuis Carbon-Copy- Added philipnienhuis
    2025-01-08 philipnienhuis StatusConfirmed Patch Submitted
    2025-01-07 swayamshah Attached File- Added 0001-updated-help-text-example.patch, #56746
    2024-12-10 rik5 Carbon-CopyRemoved 72865 -
    2024-12-09 philipnienhuis Summary[octave forge] (statistics) anovan not working [octave forge] (statistics) anovan: suggested help text example not working
    2024-12-09 philipnienhuis Item GroupUnexpected Error or Warning Documentation
        StatusNone Confirmed
        Release9.2.0 other
        Operating SystemGNU/Linux Any
    2024-12-06 philipnienhuis Carbon-Copy- Added pr0m1th3as
    2024-11-25 rik5 CategoryNone Octave Package
        Item GroupNone Unexpected Error or Warning

    Back to the top

    Powered by Savane 3.14-9aa3.
    Corresponding source code