> and added a note on the function inputs for default and max value.

Will that automatically update the online documentation, or does that need to be done elsewhere?

2048 that is

The Matlab equivalent function fircls (see https://www.mathworks.com/help/signal/ref/fircls.html) does not require a gridsize argument for the same algorithm.

The authors of the original paper cited in the cl2bp documentation published an improved algorithm in a later paper that is available at https://www.researchgate.net/publication/3316722_A_Modified_Algorithm_for_Constrained_Least_Square_Design_of_Multiband_FIR_Filters_without_Specified_Transition_Bands.

This paper mentions a grid of frequency values used for the algorithm but says: "When implementing the algorithm described herein, the frequency response can be calculated over a grid of frequency values. However, it is advised that the location of the extremal frequencies be refined by Newton’s method; otherwise, a rather dense grid is sometimes required for convergence. The use of Newton’s method is easily incorporated."

At the very least a default value of perhaps 2^8 or something similar should be provided and documented.

Quick look, accessing arg(5) when one wasnt passed in (ie: when default gridsize):

const int L = args(5).int_value(true);

Ill take a look

I can reproduce on linux / octave 9.2.1 / signal-1.4.5
+verbose+
Core was generated by `/usr/local/libexec/octave/9.2.1/exec/x86_64-pc-linux-gnu/octave-gui'.
Program terminated with signal SIGSEGV, Segmentation fault.
#0  octave_value::int_value (this=0x7faf6522c748, req_int=true, frc_str_conv=false) at /usr/local/include/octave-9.2.1/octave/../octave/ov.h:813
813   { return m_rep->int_value (req_int, frc_str_conv); }
[Current thread is 1 (Thread 0x7faf77647640 (LWP 156272))]

-verbose-

Full trace is attached.

Dmitri.
--


(file #56309)