bugGNU Octave - Bugs: bug #66021, movvar & movstd: incorrect...

 
 

bug #66021: movvar & movstd: incorrect default for OPT if [] is passed, no input validation

Submitter:  Nicholas Jankowski <nrjank>
Submitted:  Thu 25 Jul 2024 02:27:38 AM UTC
   
 
Category:  Octave Function Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Incorrect Result
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * 9.2.0 Operating System:  * Any
Fixed Release:  9.3.0 Planned Release:  9.3.0
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Fri 25 Oct 2024 09:29:10 PM UTC, comment #6: 

Changeset looks good.  I checked in some formatting tweaks here (https://hg.savannah.gnu.org/hgweb/octave/rev/8ab9ad17d3ac).

Marking as Fixed and closing report.

Rik <rik5>
Group administrator
Tue 03 Sep 2024 04:03:14 PM UTC, comment #5: 
Nicholas Jankowski <nrjank>
Group Member
Tue 03 Sep 2024 03:30:55 PM UTC, comment #4: 

confirmed. I saw zero fails and overlooked the 4 regressions on the make check for bug #66025.

Nicholas Jankowski <nrjank>
Group Member
Tue 03 Sep 2024 03:28:19 PM UTC, comment #3: 

let me go back and check. from the error message that was probably from my recent change to the input parsing.  There were a number of BISTs missing, so i might have missed that corner case.  will review and try to patch that up today.

Nicholas Jankowski <nrjank>
Group Member
Tue 03 Sep 2024 03:14:51 PM UTC, comment #2: 

The buildbots are failing with the following in the logs:

>>>>> processing /home/buildbotu/fc25-x86_64/gcc-lto-fedora/src/scripts/statistics/movstd.m
***** assert <*66021> (movstd (1:5, 3, []), [1/sqrt(2), 1, 1, 1, 1/sqrt(2)], eps)
!!!!! regression: https://octave.org/testfailure/?66021
movfun: DIM must be a positive integer-valued scalar
***** assert <*66021> (movstd (1:5, 3, [], 2), [1/sqrt(2), 1, 1, 1, 1/sqrt(2)], eps)
!!!!! regression: https://octave.org/testfailure/?66021
movfun: DIM must be a positive integer-valued scalar
>>>>> processing /home/buildbotu/fc25-x86_64/gcc-lto-fedora/src/scripts/statistics/movsum.m
>>>>> processing /home/buildbotu/fc25-x86_64/gcc-lto-fedora/src/scripts/statistics/movvar.m
***** assert <*66021> (movvar (1:5, 3, []), [0.5, 1, 1, 1, 0.5], eps)
!!!!! regression: https://octave.org/testfailure/?66021
movfun: DIM must be a positive integer-valued scalar
***** assert <*66021> (movvar (1:5, 3, [], 2), [0.5, 1, 1, 1, 0.5], eps)
!!!!! regression: https://octave.org/testfailure/?66021
movfun: DIM must be a positive integer-valued scalar


Could that be related to these changes?

Markus Mützel <mmuetzel>
Group administrator
Thu 25 Jul 2024 11:15:53 AM UTC, comment #1: 
Nicholas Jankowski <nrjank>
Group Member
Thu 25 Jul 2024 02:27:38 AM UTC, original submission:  

while working on creating BISTs for the mov* functions, I noticed that movvar and movstd treated a [] for OPT as a 1 and not a 0 (the stated default). this is also inconsistent with var & std and incompatible with matlab. In addition there was no real input validation and other things (nonscalars, etc) were allowed to pass through opt as well.

finishing a patch for stable that adds input validation on opt, corrects the default assignment, and adds the FIXME requested general function BISTs to all mov* functions.

Nicholas Jankowski <nrjank>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rik5 (Posted a comment)
  • -email is unavailable- added by mmuetzel (Posted a comment)
  • -email is unavailable- added by nrjank (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2024-10-25 rik5 StatusReady For Test Fixed
        Open/ClosedOpen Closed
        Fixed ReleaseNone 9.3.0

    Back to the top

    Powered by Savane 3.14-04e1.
    Corresponding source code