bugGNU Octave - Bugs: bug #65529, (signal) should include...

 
 

bug #65529: (signal) should include <cassert>

Submitter:  Dmitri A. Sergatskov <dasergatskov>
Submitted:  Thu 28 Mar 2024 07:31:34 PM UTC
   
 
Category:  Octave Package Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Build Failure
Status:  Ready For Test Assigned to:  None
Originator Name:  Open/Closed:  * Open
Release:  * dev Operating System:  * Any
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Thu 28 Mar 2024 08:35:41 PM UTC, comment #2: 

added to signal repo

John Donoghue <lostbard>
Group Member
Thu 28 Mar 2024 07:36:29 PM UTC, comment #1: 

CC'ing package maintainers.

The attached patch makes it compile in MXE Octave:
https://hg.octave.org/mxe-octave/file/tip/src/of-signal-1-cassert.patch


(file #55897)

Markus Mützel <mmuetzel>
Group administrator
Thu 28 Mar 2024 07:31:34 PM UTC, original submission:  

On a recent Octave 10 (dev), compilation fails:

g++ -std=gnu++17 -c  -fPIC -I/usr/local/include/octave-10.0.0/octave/.. -I/usr/local/include/octave-10.0.0/octave -I/usr/local/include  -pthread -fopenmp -ggdb3 -O2 -march=native -mtune=native -mavx -mavx2 -flto=auto  -Wall   upfirdn.cc -o /tmp/oct-bDEog8.o
remez.cc: In function ‘int Search(int, int*, int, double*)’:
remez.cc:389:3: error: ‘assert’ was not declared in this scope
  389 |   assert(extra >= 0);
      |   ^~~~~~
remez.cc:40:1: note: ‘assert’ is defined in header ‘<cassert>’; did you forget to ‘#include <cassert>’?
   39 | #include "octave-compat.h"
  +++ |+#include <cassert>
   40 |
remez.cc: In function ‘int remez(double*, int, int, const double*, const double*, const double*, int, int)’:
remez.cc:704:29: error: ‘assert’ was not declared in this scope
  704 |       for(i=0; i <= r; i++) assert(Ext[i]<gridsize);
      |                             ^~~~~~
remez.cc:704:29: note: ‘assert’ is defined in header ‘<cassert>’; did you forget to ‘#include <cassert>’?
make: *** [Makefile:48: remez.oct] Error 1


mxe-octave patch that makes it compile is here:

https://hg.octave.org/mxe-octave/rev/51670dbb688f

Discussion is here:

https://octave.discourse.group/t/assert-panic-error-and-ndebug/5409/18

Dmitri.
--

Dmitri A. Sergatskov <dasergatskov>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by lostbard (Posted a comment)
  • -email is unavailable- added by mmuetzel (Updated the item)
  • -email is unavailable- added by mmuetzel
  • -email is unavailable- added by mmuetzel
  • -email is unavailable- added by dasergatskov (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2024-03-28 lostbard StatusPatch Submitted Ready For Test
    2024-03-28 mmuetzel Attached File- Added of-signal-1-cassert.patch, #55897
        Item GroupNone Build Failure
        StatusNone Patch Submitted
        Carbon-Copy- Added mtmiller
        Carbon-Copy- Added lostbard

    Back to the top

    Powered by Savane 3.13-4448.
    Corresponding source code